Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 11094022: Fix shadowing in tests. Constructor and method are not allowed to have (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)
Modified:
8 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix shadowing in tests. Constructor and method are not allowed to have the same name. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M tests/standalone/io/echo_server_stream_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/echo_server_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_close_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_many_connections_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_stream_close_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/stream_pipe_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/testing_server.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 2 months ago (2012-10-09 11:58:15 UTC) #1
Søren Gjesse
8 years, 2 months ago (2012-10-09 12:02:25 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698