Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: tests/standalone/io/echo_server_test.dart

Issue 11094022: Fix shadowing in tests. Constructor and method are not allowed to have (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // Echo server test program for testing sockets. 5 // Echo server test program for testing sockets.
6 // 6 //
7 // VMOptions= 7 // VMOptions=
8 // VMOptions=--short_socket_read 8 // VMOptions=--short_socket_read
9 // VMOptions=--short_socket_write 9 // VMOptions=--short_socket_write
10 // VMOptions=--short_socket_read --short_socket_write 10 // VMOptions=--short_socket_read --short_socket_write
(...skipping 18 matching lines...) Expand all
29 29
30 EchoServerGame.start() 30 EchoServerGame.start()
31 : _receivePort = new ReceivePort(), 31 : _receivePort = new ReceivePort(),
32 _sendPort = null, 32 _sendPort = null,
33 _buffer = new List<int>(MSGSIZE), 33 _buffer = new List<int>(MSGSIZE),
34 _messages = 0 { 34 _messages = 0 {
35 for (int i = 0; i < MSGSIZE; i++) { 35 for (int i = 0; i < MSGSIZE; i++) {
36 _buffer[i] = FIRSTCHAR + i; 36 _buffer[i] = FIRSTCHAR + i;
37 } 37 }
38 _sendPort = spawnFunction(startEchoServer); 38 _sendPort = spawnFunction(startEchoServer);
39 start(); 39 initialize();
40 } 40 }
41 41
42 void sendData() { 42 void sendData() {
43 Socket _socket; 43 Socket _socket;
44 44
45 void messageHandler() { 45 void messageHandler() {
46 46
47 List<int> bufferReceived = new List<int>(MSGSIZE); 47 List<int> bufferReceived = new List<int>(MSGSIZE);
48 int bytesRead = 0; 48 int bytesRead = 0;
49 49
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 } 100 }
101 101
102 _socket = new Socket(TestingServer.HOST, _port); 102 _socket = new Socket(TestingServer.HOST, _port);
103 if (_socket !== null) { 103 if (_socket !== null) {
104 _socket.onConnect = connectHandler; 104 _socket.onConnect = connectHandler;
105 } else { 105 } else {
106 Expect.fail("Socket creation failed"); 106 Expect.fail("Socket creation failed");
107 } 107 }
108 } 108 }
109 109
110 void start() { 110 void initialize() {
111 _receivePort.receive((var message, SendPort replyTo) { 111 _receivePort.receive((var message, SendPort replyTo) {
112 _port = message; 112 _port = message;
113 sendData(); 113 sendData();
114 }); 114 });
115 _sendPort.send(TestingServer.INIT, _receivePort.toSendPort()); 115 _sendPort.send(TestingServer.INIT, _receivePort.toSendPort());
116 } 116 }
117 117
118 void shutdown() { 118 void shutdown() {
119 _sendPort.send(TestingServer.SHUTDOWN, _receivePort.toSendPort()); 119 _sendPort.send(TestingServer.SHUTDOWN, _receivePort.toSendPort());
120 _receivePort.close(); 120 _receivePort.close();
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 194
195 connection.onData = messageHandler; 195 connection.onData = messageHandler;
196 connection.onClosed = closeHandler; 196 connection.onClosed = closeHandler;
197 connection.onError = errorHandler; 197 connection.onError = errorHandler;
198 } 198 }
199 } 199 }
200 200
201 main() { 201 main() {
202 EchoServerTest.testMain(); 202 EchoServerTest.testMain();
203 } 203 }
OLDNEW
« no previous file with comments | « tests/standalone/io/echo_server_stream_test.dart ('k') | tests/standalone/io/socket_close_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698