Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1108913003: Use Map<FieldElement, ConstantValue> for fields in ConstructedConstantValue. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use Map<FieldElement, ConstantValue> for fields in ConstructedConstantValue. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -120 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 3 chunks +12 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 6 chunks +16 lines, -58 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart View 2 chunks +6 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 3 chunks +5 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/util/util.dart View 1 chunk +47 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-04-28 09:38:19 UTC) #2
karlklose
LGTM.
5 years, 7 months ago (2015-04-28 09:52:09 UTC) #3
Johnni Winther
5 years, 7 months ago (2015-04-28 10:49:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45441 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698