pkg/compiler/lib/src/js_backend/namer.dart - Issue 1108913003: Use Map<FieldElement, ConstantValue> for fields in ConstructedConstantValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 1108913003: Use Map<FieldElement, ConstantValue> for fields in ConstructedConstantValue. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/constant_emitter.dart ('k') | pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/namer.dart

diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart

index 85bdd5c04214bf527eced2da214f3e5216fc49c2..4e15e5d3e00dbf2521b3a692de151a9562a7e4f9 100644

--- a/pkg/compiler/lib/src/js_backend/namer.dart

+++ b/pkg/compiler/lib/src/js_backend/namer.dart

@@ -1508,8 +1508,8 @@ class ConstantNamingVisitor implements ConstantValueVisitor {

@override

void visitConstructed(ConstructedConstantValue constant, [_]) {

addRoot(constant.type.element.name);

- for (int i = 0; i < constant.fields.length; i++) {

- _visit(constant.fields[i]);

+ for (ConstantValue value in constant.fields.values) {

+ _visit(value);

if (failed) return;

}

@@ -1612,8 +1612,8 @@ class ConstantCanonicalHasher implements ConstantValueVisitor<int, Null> {

@override

int visitConstructed(ConstructedConstantValue constant, [_]) {

int hash = _hashString(3, constant.type.element.name);

- for (int i = 0; i < constant.fields.length; i++) {

- hash = _combine(hash, _visit(constant.fields[i]));

+ for (ConstantValue value in constant.fields.values) {

+ hash = _combine(hash, _visit(value));

}

return hash;

}