Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart

Issue 1108913003: Use Map<FieldElement, ConstantValue> for fields in ConstructedConstantValue. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/mirrors_used.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart
diff --git a/pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart b/pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart
index f5e4b119f1128d2c98393bf0613e5fdcd80878b2..b29b582229bfcab7dfee5ea5110b60c476ebc3e9 100644
--- a/pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart
+++ b/pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart
@@ -229,7 +229,7 @@ class Dart2JsTypeConstantMirror extends Dart2JsConstantMirror
}
class Dart2JsConstructedConstantMirror extends Dart2JsConstantMirror {
- Map<String,ConstantValue> _fieldMapCache;
+ Map<String, ConstantValue> _fieldMapCache;
Dart2JsConstructedConstantMirror(Dart2JsMirrorSystem mirrorSystem,
ConstantExpression constant,
@@ -238,17 +238,13 @@ class Dart2JsConstructedConstantMirror extends Dart2JsConstantMirror {
ConstructedConstantValue get _value => super._value;
- Map<String,ConstantValue> get _fieldMap {
+ Map<String, ConstantValue> get _fieldMap {
if (_fieldMapCache == null) {
- _fieldMapCache = new Map<String,ConstantValue>();
+ _fieldMapCache = new Map<String, ConstantValue>();
if (identical(_value.type.element.kind, ElementKind.CLASS)) {
- var index = 0;
- ClassElement element = _value.type.element;
- element.forEachInstanceField((_, Element field) {
- String fieldName = field.name;
- _fieldMapCache.putIfAbsent(fieldName, () => _value.fields[index]);
- index++;
- }, includeSuperAndInjectedMembers: true);
+ _value.fields.forEach((FieldElement field, ConstantValue value) {
+ _fieldMapCache[field.name] = value;
+ });
}
}
return _fieldMapCache;
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/mirrors_used.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698