Remove function types from intl, as they appear to break the vm

Remove function types from intl, as they appear to break the vm
Committed: https://code.google.com/p/dart/source/detail?r=13485

[Alan Knight, 2012-10-10 17:01:46]

TBR.

The attempt to make more rigorous function types in Intl appears to break the VM
on the buildbots (though not locally).  Removing them.

[Emily Fortuna, 2012-10-10 17:44:48]

lgtm

https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart
File pkg/intl/lib/intl.dart (left):

https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart#oldcod...
pkg/intl/lib/intl.dart:235: static dynamic withLocale(String locale,
message_function()) {
hmm bummer. So neither the VM nor dart2js recognize this syntax yet?

[Alan Knight, 2012-10-10 17:49:05]

https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart
File pkg/intl/lib/intl.dart (left):

https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart#oldcod...
pkg/intl/lib/intl.dart:235: static dynamic withLocale(String locale,
message_function()) {
On 2012/10/10 17:44:48, Emily Fortuna wrote:
> hmm bummer. So neither the VM nor dart2js recognize this syntax yet?
Looks like the problem was probably the explicit use of dynamic. At least this
didn't fix it, and removing dynamic did. Dart2js has problems with more complex
versions of this, but seems like it's probably ok with this one. So this could
be put back, but since it all works fine locally, so I can only test it by
committing and watching the bots, maybe I'll wait and revisit it when we're not
in a crunch.

[Emily Fortuna, 2012-10-10 18:11:06]

https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart
File pkg/intl/lib/intl.dart (left):

https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart#oldcod...
pkg/intl/lib/intl.dart:235: static dynamic withLocale(String locale,
message_function()) {
On 2012/10/10 17:49:05, Alan Knight wrote:
> On 2012/10/10 17:44:48, Emily Fortuna wrote:
> > hmm bummer. So neither the VM nor dart2js recognize this syntax yet?
> Looks like the problem was probably the explicit use of dynamic. At least this
> didn't fix it, and removing dynamic did. Dart2js has problems with more
complex
> versions of this, but seems like it's probably ok with this one. So this could
> be put back, but since it all works fine locally, so I can only test it by
> committing and watching the bots, maybe I'll wait and revisit it when we're
not
> in a crunch.

sgtm. I support the more specific syntax

[Ivan Posva, 2012-10-10 19:01:55]

https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart
File pkg/intl/lib/intl.dart (left):

https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart#oldcod...
pkg/intl/lib/intl.dart:235: static dynamic withLocale(String locale,
message_function()) {
On 2012/10/10 18:11:07, Emily Fortuna wrote:
> On 2012/10/10 17:49:05, Alan Knight wrote:
> > On 2012/10/10 17:44:48, Emily Fortuna wrote:
> > > hmm bummer. So neither the VM nor dart2js recognize this syntax yet?
> > Looks like the problem was probably the explicit use of dynamic. At least
this
> > didn't fix it, and removing dynamic did. Dart2js has problems with more
> complex
> > versions of this, but seems like it's probably ok with this one. So this
could
> > be put back, but since it all works fine locally, so I can only test it by
> > committing and watching the bots, maybe I'll wait and revisit it when we're
> not
> > in a crunch.
> 
> sgtm. I support the more specific syntax

The problem here is that "dynamic" is not a known type. The rename from Dynamic
to dynamic is not implemented in either dart2js or the VM.

[Alan Knight, 2012-10-10 19:29:26]

On 2012/10/10 19:01:55, Ivan Posva wrote:
> https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart
> File pkg/intl/lib/intl.dart (left):
> 
>
https://codereview.chromium.org/11066099/diff/1/pkg/intl/lib/intl.dart#oldcod...
> pkg/intl/lib/intl.dart:235: static dynamic withLocale(String locale,
> message_function()) {
> On 2012/10/10 18:11:07, Emily Fortuna wrote:
> > On 2012/10/10 17:49:05, Alan Knight wrote:
> > > On 2012/10/10 17:44:48, Emily Fortuna wrote:
> > > > hmm bummer. So neither the VM nor dart2js recognize this syntax yet?
> > > Looks like the problem was probably the explicit use of dynamic. At least
> this
> > > didn't fix it, and removing dynamic did. Dart2js has problems with more
> > complex
> > > versions of this, but seems like it's probably ok with this one. So this
> could
> > > be put back, but since it all works fine locally, so I can only test it by
> > > committing and watching the bots, maybe I'll wait and revisit it when
we're
> > not
> > > in a crunch.
> > 
> > sgtm. I support the more specific syntax
> 
> The problem here is that "dynamic" is not a known type. The rename from
Dynamic
> to dynamic is not implemented in either dart2js or the VM.

Ah. It seems like it must be implemented on dart2js, as the code runs fine
there. But that makes sense, although it would be better if an unknown type
there was a compile error rather than a crash.