Remove function types from intl, as they appear to break the vm

pkg/intl/lib/intl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This library provides internationalization and localization. This includes
  * message formatting and replacement, date and number formatting and parsing,
  * and utilities for working with Bidirectional text.
  *
  * For things that require locale or other data, there are multiple different
@@ skipping 140 matching lines @@
   /**
    * Given [newLocale] return a locale that we have data for that is similar
    * to it, if possible.
    * If [newLocale] is found directly, return it. If it can't be found, look up
    * based on just the language (e.g. 'en_CA' -> 'en'). Also accepts '-'
    * as a separator and changes it into '_' for lookup, and changes the
    * country to uppercase.
    * Note that null is interpreted as meaning the default locale, so if
    * [newLocale] is null it will be returned.
    */
-  static String verifiedLocale(String newLocale, bool localeExists(String),
+  static String verifiedLocale(String newLocale, Function localeExists,
                                [Function onFailure = _throwLocaleError]) {
     // TODO(alanknight): Previously we kept a single verified locale on the Intl
     // object, but with different verification for different uses, that's more
     // difficult. As a result, we call this more often. Consider keeping
     // verified locales for each purpose if it turns out to be a performance
     // issue.
     if (newLocale == null) return systemLocale;
     if (localeExists(newLocale)) {
       return newLocale;
     }
@@ skipping 53 matching lines @@
    * [message_function] that takes no parameters. The [message_function] can be
    * a simple message function that just returns the result of `Intl.message()`
    * it can be a wrapper around a message function that takes arguments, or it
    * can be something more complex that manipulates multiple message
    * functions.
    *
    * In either case, the purpose of this is to delay calling [message_function]
    * until the proper locale has been set. This returns the result of calling
    * [msg_function], which could be of an arbitrary type.
    */
-  static dynamic withLocale(String locale, message_function()) {

[Emily Fortuna, 2012/10/10 17:44:48]

hmm bummer. So neither the VM nor dart2js recognize this syntax yet?

[Alan Knight, 2012/10/10 17:49:05]

Looks like the problem was probably the explicit use of dynamic. At least this
didn't fix it, and removing dynamic did. Dart2js has problems with more complex
versions of this, but seems like it's probably ok with this one. So this could
be put back, but since it all works fine locally, so I can only test it by
committing and watching the bots, maybe I'll wait and revisit it when we're not
in a crunch.

[Emily Fortuna, 2012/10/10 18:11:07]

sgtm. I support the more specific syntax

[Ivan Posva, 2012/10/10 19:01:55]

The problem here is that "dynamic" is not a known type. The rename from Dynamic
to dynamic is not implemented in either dart2js or the VM.

+  static dynamic withLocale(String locale, Function message_function) {
     // We have to do this silliness because Locale is not known at compile time,
     // but must be a static variable in order to be visible to the Intl.message
     // invocation.
     if (_defaultLocale == null) _defaultLocale = systemLocale;
     var oldLocale = _defaultLocale;
     _defaultLocale = locale;
     var result = message_function();
     _defaultLocale = oldLocale;
     return result;
   }
@@ skipping 15 matching lines @@
   /**
    * Accessor for the current locale. This should always == the default locale,
    * unless for some reason this gets called inside a message that resets the
    * locale.
    */
   static String getCurrentLocale() {
     if (_defaultLocale == null) _defaultLocale = systemLocale;
     return _defaultLocale;
   }
 }