Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pkg/intl/lib/intl.dart

Issue 11066099: Remove function types from intl, as they appear to break the vm (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/intl.dart
===================================================================
--- pkg/intl/lib/intl.dart (revision 13484)
+++ pkg/intl/lib/intl.dart (working copy)
@@ -158,7 +158,7 @@
* Note that null is interpreted as meaning the default locale, so if
* [newLocale] is null it will be returned.
*/
- static String verifiedLocale(String newLocale, bool localeExists(String),
+ static String verifiedLocale(String newLocale, Function localeExists,
[Function onFailure = _throwLocaleError]) {
// TODO(alanknight): Previously we kept a single verified locale on the Intl
// object, but with different verification for different uses, that's more
@@ -232,7 +232,7 @@
* until the proper locale has been set. This returns the result of calling
* [msg_function], which could be of an arbitrary type.
*/
- static dynamic withLocale(String locale, message_function()) {
Emily Fortuna 2012/10/10 17:44:48 hmm bummer. So neither the VM nor dart2js recogniz
Alan Knight 2012/10/10 17:49:05 Looks like the problem was probably the explicit u
Emily Fortuna 2012/10/10 18:11:07 sgtm. I support the more specific syntax
Ivan Posva 2012/10/10 19:01:55 The problem here is that "dynamic" is not a known
+ static dynamic withLocale(String locale, Function message_function) {
// We have to do this silliness because Locale is not known at compile time,
// but must be a static variable in order to be visible to the Intl.message
// invocation.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698