Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 11047013: Minor fixes to test.dart. (Closed)

Created:
8 years, 2 months ago by Mads Ager (google)
Modified:
8 years, 2 months ago
Reviewers:
ricow1, Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Minor fixes to test.dart. Fix some switches, remove interfaces, and add 'incomplete' to the TestOutput abstract class. R=ricow@google.com,whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13169

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M tests/co19/test_config.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/status_expression.dart View 4 chunks +6 lines, -7 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 3 chunks +21 lines, -12 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 3 chunks +2 lines, -3 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
8 years, 2 months ago (2012-10-03 09:36:51 UTC) #1
ricow1
LGTM with one question https://codereview.chromium.org/11047013/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (left): https://codereview.chromium.org/11047013/diff/1/tools/testing/dart/test_suite.dart#oldcode836 tools/testing/dart/test_suite.dart:836: Expect.fail("configuration['runtime'] is not set"); if ...
8 years, 2 months ago (2012-10-03 10:39:02 UTC) #2
Mads Ager (google)
https://codereview.chromium.org/11047013/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (left): https://codereview.chromium.org/11047013/diff/1/tools/testing/dart/test_suite.dart#oldcode836 tools/testing/dart/test_suite.dart:836: Expect.fail("configuration['runtime'] is not set"); On 2012/10/03 10:39:03, ricow1 wrote: ...
8 years, 2 months ago (2012-10-03 10:44:10 UTC) #3
Mads Ager (google)
8 years, 2 months ago (2012-10-03 10:46:29 UTC) #4
On 2012/10/03 10:44:10, Mads Ager wrote:
>
https://codereview.chromium.org/11047013/diff/1/tools/testing/dart/test_suite...
> File tools/testing/dart/test_suite.dart (left):
> 
>
https://codereview.chromium.org/11047013/diff/1/tools/testing/dart/test_suite...
> tools/testing/dart/test_suite.dart:836: Expect.fail("configuration['runtime']
is
> not set");
> On 2012/10/03 10:39:03, ricow1 wrote:
> > if we don't pass runtime in on the command line don't we hit this?
> 
> At this point I'm just cleaning this up. 'runtime' is always set. The option
has
> a default value 'vm' which you can overwrite, so this method is a no-op. I was
> just doing this in passing, but this hasRuntime check should go away.

That is not true, it shouldn't go away. What I did was the right thing. It will
never be null but it could be 'none'. :-)

Powered by Google App Engine
This is Rietveld 408576698