Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2032)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11046025: Adding synchronous measurement methods to Element. (Closed)

Created:
8 years, 2 months ago by blois
Modified:
8 years, 2 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding synchronous measurement methods to Element. I also did some refactoring unit tests some so element_test passes on all browsers- it seems quite bad that element_test was expected to fail on so many configurations. Ideally this gets refactored further when our browser support gets flushed out further. BUG=838 Committed: https://code.google.com/p/dart/source/detail?r=13246

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporating review feedback and fixing safari test. #

Patch Set 3 : Re-adding mistakenly removed Element.rect API. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -152 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 9 chunks +44 lines, -48 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 7 chunks +44 lines, -44 lines 0 comments Download
M lib/html/scripts/htmlrenamer.py View 1 1 chunk +0 lines, -14 lines 0 comments Download
M lib/html/templates/html/dart2js/impl_MouseEvent.darttemplate View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lib/html/templates/html/impl/impl_Element.darttemplate View 1 1 chunk +14 lines, -14 lines 2 comments Download
M tests/html/element_test.dart View 1 8 chunks +38 lines, -27 lines 0 comments Download
A tests/html/element_webkit_test.dart View 1 1 chunk +80 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
blois
8 years, 2 months ago (2012-10-03 23:00:52 UTC) #1
Jacob
https://codereview.chromium.org/11046025/diff/1/lib/html/templates/html/impl/impl_Element.darttemplate File lib/html/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/11046025/diff/1/lib/html/templates/html/impl/impl_Element.darttemplate#newcode709 lib/html/templates/html/impl/impl_Element.darttemplate:709: ClientRect get client => new _SimpleClientRect( also go ahead ...
8 years, 2 months ago (2012-10-03 23:08:53 UTC) #2
blois
Fixed that, also fixed a typo I had which was causing the new webkit-specific tests ...
8 years, 2 months ago (2012-10-03 23:36:09 UTC) #3
Jacob
https://codereview.chromium.org/11046025/diff/6010/lib/html/templates/html/impl/impl_Element.darttemplate File lib/html/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/11046025/diff/6010/lib/html/templates/html/impl/impl_Element.darttemplate#newcode627 lib/html/templates/html/impl/impl_Element.darttemplate:627: _ElementRectImpl(_ElementImpl element) : why is ElementRectImpl still around?
8 years, 2 months ago (2012-10-04 00:29:37 UTC) #4
blois
https://codereview.chromium.org/11046025/diff/6010/lib/html/templates/html/impl/impl_Element.darttemplate File lib/html/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/11046025/diff/6010/lib/html/templates/html/impl/impl_Element.darttemplate#newcode627 lib/html/templates/html/impl/impl_Element.darttemplate:627: _ElementRectImpl(_ElementImpl element) : On 2012/10/04 00:29:38, Jacob wrote: > ...
8 years, 2 months ago (2012-10-04 00:32:46 UTC) #5
Jacob
8 years, 2 months ago (2012-10-04 17:35:50 UTC) #6 
Makes sense. 
Go ahead and add @deprecated to the methods you intend to stop supporting.

Powered by Google App Engine
This is Rietveld 408576698