Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: lib/html/templates/html/impl/impl_Element.darttemplate

Issue 11046025: Adding synchronous measurement methods to Element. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Re-adding mistakenly removed Element.rect API. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/templates/html/dart2js/impl_MouseEvent.darttemplate ('k') | tests/html/element_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/templates/html/impl/impl_Element.darttemplate
diff --git a/lib/html/templates/html/impl/impl_Element.darttemplate b/lib/html/templates/html/impl/impl_Element.darttemplate
index 9a0928b7d2040a22f9819f52f8ffaea29742c029..7e0732c021149ea959b39111d0da79a1566ae63c 100644
--- a/lib/html/templates/html/impl/impl_Element.darttemplate
+++ b/lib/html/templates/html/impl/impl_Element.darttemplate
@@ -625,20 +625,20 @@ class _ElementRectImpl implements ElementRect {
final _ClientRectListImpl _clientRects;
_ElementRectImpl(_ElementImpl element) :
Jacob 2012/10/04 00:29:38 why is ElementRectImpl still around?
blois 2012/10/04 00:32:46 This only adds the synchronous methods, does not r
- client = new _SimpleClientRect(element.$dom_clientLeft,
- element.$dom_clientTop,
- element.$dom_clientWidth,
- element.$dom_clientHeight),
- offset = new _SimpleClientRect(element.$dom_offsetLeft,
- element.$dom_offsetTop,
- element.$dom_offsetWidth,
- element.$dom_offsetHeight),
- scroll = new _SimpleClientRect(element.$dom_scrollLeft,
- element.$dom_scrollTop,
- element.$dom_scrollWidth,
- element.$dom_scrollHeight),
- _boundingClientRect = element.$dom_getBoundingClientRect(),
- _clientRects = element.$dom_getClientRects();
+ client = new _SimpleClientRect(element.clientLeft,
+ element.clientTop,
+ element.clientWidth,
+ element.clientHeight),
+ offset = new _SimpleClientRect(element.offsetLeft,
+ element.offsetTop,
+ element.offsetWidth,
+ element.offsetHeight),
+ scroll = new _SimpleClientRect(element.scrollLeft,
+ element.scrollTop,
+ element.scrollWidth,
+ element.scrollHeight),
+ _boundingClientRect = element.getBoundingClientRect(),
+ _clientRects = element.getClientRects();
_ClientRectImpl get bounding => _boundingClientRect;
« no previous file with comments | « lib/html/templates/html/dart2js/impl_MouseEvent.darttemplate ('k') | tests/html/element_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698