Adding synchronous measurement methods to Element.

lib/html/templates/html/impl/impl_Element.darttemplate

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(jacobr): use _Lists.dart to remove some of the duplicated
 // functionality.
 class _ChildrenElementList implements List {
   // Raw Element.
   final _ElementImpl _element;
   final _HTMLCollectionImpl _childElements;
@@ skipping 688 matching lines @@
       dataAttributes[key] = value[key];
     }
   }
 
   Future<ElementRect> get rect {
     return _createMeasurementFuture(
         () => new _ElementRectImpl(this),
         new Completer<ElementRect>());
   }
 
+  ClientRect get client => new _SimpleClientRect(

[Jacob, 2012/10/03 23:08:53]

also go ahead and remove that these are rects.  the fact that they are rects is
misleading.  they are really offsets/margins/border widths depending on the
case.
just match the js names and call it a day.

[blois, 2012/10/03 23:36:09]

Done.

+      this.$dom_clientLeft,
+      this.$dom_clientTop,
+      this.$dom_clientWidth,
+      this.$dom_clientHeight);
+
+  ClientRect get offset => new _SimpleClientRect(
+      this.$dom_offsetLeft,
+      this.$dom_offsetTop,
+      this.$dom_offsetWidth,
+      this.$dom_offsetHeight);
+
+  ClientRect get scroll => new _SimpleClientRect(
+      this.$dom_scrollLeft,
+      this.$dom_scrollTop,
+      this.$dom_scrollWidth,
+      this.$dom_scrollHeight);
+
+  ClientRect get boundingClientRect => this.$dom_getBoundingClientRect();
+
   Future<CSSStyleDeclaration> get computedStyle {
      // TODO(jacobr): last param should be null, see b/5045788
      return getComputedStyle('');
   }
 
   Future<CSSStyleDeclaration> getComputedStyle(String pseudoElement) {
     return _createMeasurementFuture(
         () => _window.$dom_getComputedStyle(this, pseudoElement),
         new Completer<CSSStyleDeclaration>());
   }
@@ skipping 143 matching lines @@
 $if DART2JS
   // Optimization to improve performance until the dart2js compiler inlines this
   // method.
   static Element createElement_tag(String tag)
       native "return document.createElement(tag)";
 $else
   static Element createElement_tag(String tag) =>
       _document.$dom_createElement(tag);
 $endif
 }