Fix issues with test.dart that appeared on Mac.

Fix issues with test.dart that appeared on Mac.

The issue was that we did not properly wait for subprocesses to
die. This was hidden by the fact that we always used exit to exit from
test.dart. I have removed all exit(0) calls from test.dart to keep us
honest. If nothing went wrong test.dart should terminate with exit
code 0 automatically.

R=ricow@google.com,ahe@google.com
BUG=dartbug.com/5644

Committed: https://code.google.com/p/dart/source/detail?r=13286

[ahe, 2012-10-05 11:40:44]

LGTM!

[ricow1, 2012-10-05 11:41:29]

LGTM

[regis, 2012-10-05 18:48:52]

On 2012/10/05 11:41:29, ricow1 wrote:
> LGTM

It appears that since this cl, it is not possible to run 2 simultaneous
instances of test.py anymore:

Error Bind: Address already in use
Unhandled exception:
SocketIOException: Failed to create server socket (OS Error: Address already in
use, errno = 98)
#0      _ServerSocket._ServerSocket (dart:io:5771:13)
#1      ServerSocket.ServerSocket (dart:io:5526:16)
#2      _HttpServer.listen (dart:io:3125:14)
#3      startHttpServer
(file:///usr/local/google/home/regis/dart1/dart/tools/testing/dart/http_server.dart:45:21)
#4      main
(file:///usr/local/google/home/regis/dart1/dart/tools/test.dart:130:34)

[regis, 2012-10-05 19:41:10]

On 2012/10/05 18:48:52, regis wrote:
> On 2012/10/05 11:41:29, ricow1 wrote:
> > LGTM
> 
> It appears that since this cl, it is not possible to run 2 simultaneous
> instances of test.py anymore:
> 
> Error Bind: Address already in use
> Unhandled exception:
> SocketIOException: Failed to create server socket (OS Error: Address already
in
> use, errno = 98)
> #0      _ServerSocket._ServerSocket (dart:io:5771:13)
> #1      ServerSocket.ServerSocket (dart:io:5526:16)
> #2      _HttpServer.listen (dart:io:3125:14)
> #3      startHttpServer
>
(file:///usr/local/google/home/regis/dart1/dart/tools/testing/dart/http_server.dart:45:21)
> #4      main
> (file:///usr/local/google/home/regis/dart1/dart/tools/test.dart:130:34)

Actually, the problem precedes this cl. Sorry about the wrong comment.
However, it would be nice to use a dynamic port to avoid this issue.

Thanks,
Regis

[Emily Fortuna, 2012-10-06 00:11:55]

https://codereview.chromium.org/11032047/diff/1/tools/testing/dart/test_progr...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/11032047/diff/1/tools/testing/dart/test_progr...
tools/testing/dart/test_progress.dart:89: if (_failedTests) exit(1);
if(3) is equivalent to if(false). I fixed this in this CL:
https://codereview.chromium.org/11071003/

https://codereview.chromium.org/11032047/diff/1/tools/testing/dart/test_runne...
File tools/testing/dart/test_runner.dart (left):

https://codereview.chromium.org/11032047/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:757: if (_isWebDriver) {
DBC -- why are no longer doing this graceful shutdown for the browser tests?
This can result in 100s of browser windows open on test failures.

[Mads Ager (google), 2012-10-06 06:24:08]

https://codereview.chromium.org/11032047/diff/1/tools/testing/dart/test_progr...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/11032047/diff/1/tools/testing/dart/test_progr...
tools/testing/dart/test_progress.dart:89: if (_failedTests) exit(1);
On 2012/10/06 00:11:55, Emily Fortuna wrote:
> if(3) is equivalent to if(false). I fixed this in this CL:
> https://codereview.chromium.org/11071003/

Thanks for the fix!

https://codereview.chromium.org/11032047/diff/1/tools/testing/dart/test_runne...
File tools/testing/dart/test_runner.dart (left):

https://codereview.chromium.org/11032047/diff/1/tools/testing/dart/test_runne...
tools/testing/dart/test_runner.dart:757: if (_isWebDriver) {
On 2012/10/06 00:11:55, Emily Fortuna wrote:
> DBC -- why are no longer doing this graceful shutdown for the browser tests?
> This can result in 100s of browser windows open on test failures.

Because the TODO has been fixed and a kill sends the right signal to do a
graceful shutdown. Additionally, this code makes test.dart hang for 30 seconds
no matter if the processes are dead or not because we have to wait for the 30
second timeout to fire.