Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 11032047: Fix issues with test.dart that appeared on Mac. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 1f1f55702609dbaac0b231f361c002e50877f91a..a1830e0f8d702903a26c41b8f177e5a174740345 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -84,7 +84,9 @@ class ProgressIndicator {
_printFailureSummary();
_printStatus();
_printTimingInformation();
- exit(_failedTests > 0 ? 1 : 0);
+ stdout.close();
+ stderr.close();
+ if (_failedTests) exit(1);
Emily Fortuna 2012/10/06 00:11:55 if(3) is equivalent to if(false). I fixed this in
Mads Ager (google) 2012/10/06 06:24:09 Thanks for the fix!
}
void _printStartProgress(TestCase test) {}
@@ -215,9 +217,7 @@ class SilentProgressIndicator extends ProgressIndicator {
void _printStartProgress(TestCase test) { }
void _printDoneProgress(TestCase test) { }
void allTestsKnown() { }
- void allDone() {
- exit(0);
- }
+ void allDone() { }
}
abstract class CompactIndicator extends ProgressIndicator {
@@ -234,7 +234,8 @@ abstract class CompactIndicator extends ProgressIndicator {
print('');
}
stdout.close();
- exit(_failedTests > 0 ? 1 : 0);
+ stderr.close();
+ if (_failedTests) exit(1);
}
void allTestsKnown() {

Powered by Google App Engine
This is Rietveld 408576698