Issue 11071003: Fix test.dart return code -- was causing fake greenness on dartc, dart2dart

Issue 11071003: Fix test.dart return code -- was causing fake greenness on dartc, dart2dart (Closed)

Created:
8 years, 2 months ago by Emily Fortuna

Modified:
8 years, 2 months ago

Reviewers:
Mads Ager (google), gram, Ivan Posva

CC:
reviews_dartlang.org, ricow1, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix test.dart return code -- was causing fake greenness on dartc, dart2dart (potentially the VM) as a result of previous CL: https://codereview.chromium.org/11032047/ Committed: https://code.google.com/p/dart/source/detail?r=13336

Patch Set 1 : #

Total comments: 3

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tests/co19/co19-compiler.status	View		1 chunk	+0 lines, -1 line	1 comment	Download
	M	tools/testing/dart/test_progress.dart	View		2 chunks	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/11071003/diff/2001/tests/co19/co19-compiler.status File tests/co19/co19-compiler.status (left): https://codereview.chromium.org/11071003/diff/2001/tests/co19/co19-compiler.status#oldcode6 tests/co19/co19-compiler.status:6: Language/03_Overview/1_Scoping_A02_t05: Fail # TODO(analyzer-team): Please triage this failure. I'm ...

8 years, 2 months ago (2012-10-06 00:08:58 UTC) #1

Mads Ager (google)

LGTM! Urgh, this is exactly the kind of thing I wanted us to avoid. We ...

8 years, 2 months ago (2012-10-06 06:16:35 UTC) #3

Ivan Posva

8 years, 2 months ago (2012-10-11 04:40:39 UTC) #4

https://codereview.chromium.org/11071003/diff/2001/tools/testing/dart/test_pr...
File tools/testing/dart/test_progress.dart (right):

https://codereview.chromium.org/11071003/diff/2001/tools/testing/dart/test_pr...
tools/testing/dart/test_progress.dart:89: if (_failedTests > 0) exit(1);
On 2012/10/06 06:16:36, Mads Ager wrote:
> Oh my. :(

Shouldn't this have failed in checked mode? Maybe it is time to run the test
harness in checked mode occasionally? Or at least when modifying the harness
itself?

Expand Messages | Collapse Messages