Reland support for firefox jsshell.

Reland support for firefox jsshell.

The change compared to:
http://code.google.com/p/dart/source/detail?r=13230

is that we by default inherit the environment from the parent process
and that when actually setting LD_LIBRARY_PATH for linux we do this in
_addition_ to the existing environment.
Committed: https://code.google.com/p/dart/source/detail?r=13290

[Mads Ager (google), 2012-10-05 08:22:48]

LGTM! Thanks!

[ahe, 2012-10-05 08:25:59]

Wouldn't it be simpler to set LD_LIBRARY_PATH in a shell script wrapper?

Alternatively, link the Linux binary with:

gcc -Wl,-rpath,'$ORIGIN' ...

[ricow1, 2012-10-05 08:33:45]

Peter,
For this specific case we could do a wrapper script, please consider my comments
below and let me know if you think we should change it and I will do that.

On 2012/10/05 08:25:59, ahe wrote:
> Wouldn't it be simpler to set LD_LIBRARY_PATH in a shell script wrapper?
Having support for setting environment variables in the test scrips seems
reasonable from my perspective. I think (I hope not, but I think) that we will
unfortunately need more of this if/when we start testing on arm.

> 
> Alternatively, link the Linux binary with:
> 
> gcc -Wl,-rpath,'$ORIGIN' ...
We are not building the binary ourselves, we are pulling it from the firefox ftp

[ricow1, 2012-10-05 12:18:29]

As discussed offline I actually changed this to use a wrapper, PTAL

On 2012/10/05 08:33:45, ricow1 wrote:
> Peter,
> For this specific case we could do a wrapper script, please consider my
comments
> below and let me know if you think we should change it and I will do that.
> 
> On 2012/10/05 08:25:59, ahe wrote:
> > Wouldn't it be simpler to set LD_LIBRARY_PATH in a shell script wrapper?
> Having support for setting environment variables in the test scrips seems
> reasonable from my perspective. I think (I hope not, but I think) that we will
> unfortunately need more of this if/when we start testing on arm.
> 
> > 
> > Alternatively, link the Linux binary with:
> > 
> > gcc -Wl,-rpath,'$ORIGIN' ...
> We are not building the binary ourselves, we are pulling it from the firefox
ftp

[ahe, 2012-10-05 12:46:45]

LGTM!

https://codereview.chromium.org/11031064/diff/6/tools/testing/bin/jsshell
File tools/testing/bin/jsshell (right):

https://codereview.chromium.org/11031064/diff/6/tools/testing/bin/jsshell#new...
tools/testing/bin/jsshell:12:
LD_LIBRARY_PATH=${0%/*}/../../../third_party/firefox_jsshell/linux/ exec
${0%/*}/../../../third_party/firefox_jsshell/linux/js "$@"
Wrap line with \ (backslash)

https://codereview.chromium.org/11031064/diff/6/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11031064/diff/6/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1408: var jsshellDir =
'$root/tools/testing/bin';
You could also write: ${dartDir()}

[ricow1, 2012-10-05 12:49:56]

https://codereview.chromium.org/11031064/diff/6/tools/testing/bin/jsshell
File tools/testing/bin/jsshell (right):

https://codereview.chromium.org/11031064/diff/6/tools/testing/bin/jsshell#new...
tools/testing/bin/jsshell:12:
LD_LIBRARY_PATH=${0%/*}/../../../third_party/firefox_jsshell/linux/ exec
${0%/*}/../../../third_party/firefox_jsshell/linux/js "$@"
On 2012/10/05 12:46:45, ahe wrote:
> Wrap line with \ (backslash)

Done.

https://codereview.chromium.org/11031064/diff/6/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11031064/diff/6/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1408: var jsshellDir =
'$root/tools/testing/bin';
On 2012/10/05 12:46:45, ahe wrote:
> You could also write: ${dartDir()}

Done.