Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11031064: Reland support for firefox jsshell. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 13274)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -469,6 +469,9 @@
} else if (configuration['runtime'] == 'd8') {
var d8 = TestUtils.d8FileName(configuration);
commands.add(new Command(d8, ['$tempDir/out.js']));
+ } else if (configuration['runtime'] == 'jsshell') {
+ var jsshell = TestUtils.jsshellFileName(configuration);
+ commands.add(new Command(jsshell, ['$tempDir/out.js']));
}
return commands;
@@ -1398,6 +1401,13 @@
return args;
}
+ static String jsshellFileName(Map configuration) {
+ var executableSuffix = executableSuffix('jsshell');
+ var executable = 'jsshell$executableSuffix';
+ var jsshellDir = '${dartDir()}/tools/testing/bin';
+ return '$jsshellDir/$executable';
+ }
+
static bool isBrowserRuntime(String runtime) => Contains(
runtime,
const <String>['drt',
@@ -1407,6 +1417,10 @@
'opera',
'chrome',
'ff']);
+
+ static bool isJsCommandLineRuntime(String runtime) =>
+ Contains(runtime, const <String>['d8', 'jsshell']);
+
}
class SummaryReport {
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698