Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: tools/testing/dart/test_options.dart

Issue 11031064: Reland support for firefox jsshell. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/bin/jsshell.bat ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
===================================================================
--- tools/testing/dart/test_options.dart (revision 13274)
+++ tools/testing/dart/test_options.dart (working copy)
@@ -88,6 +88,8 @@
d8: Run JavaScript from the command line using v8.
+ jsshell: Run JavaScript from the command line using firefox js-shell.
+
drt: Run Dart or JavaScript in the headless version of Chrome,
DumpRenderTree.
@@ -99,8 +101,8 @@
none: No runtime, compile only (for example, used for dartc static analysis
tests).''',
['-r', '--runtime'],
- ['vm', 'd8', 'drt', 'dartium', 'ff', 'firefox', 'chrome',
- 'safari', 'ie', 'opera', 'none'],
+ ['vm', 'd8', 'jsshell', 'drt', 'dartium', 'ff', 'firefox',
+ 'chrome', 'safari', 'ie', 'opera', 'none'],
'vm'),
new _TestOptionSpecification(
'arch',
@@ -395,7 +397,7 @@
// runs test.py -c dart2js -r drt,none the dart2js_none and
// dart2js_drt will be duplicating work. If later we don't need 'none'
// with dart2js, we should remove it from here.
- validRuntimes = const ['d8', 'drt', 'none', 'dartium',
+ validRuntimes = const ['d8', 'jsshell', 'drt', 'none', 'dartium',
'ff', 'chrome', 'safari', 'ie', 'opera'];
break;
case 'dartc':
@@ -473,10 +475,11 @@
configuration['runtime'] == 'ff';
}
- if (TestUtils.isBrowserRuntime(runtime)) {
- configuration['browser'] = true;
- }
+ configuration['browser'] = TestUtils.isBrowserRuntime(runtime);
+ // Set the javascript command line flag for less verbose status files.
+ configuration['jscl'] = TestUtils.isJsCommandLineRuntime(runtime);
+
// Expand the test selectors into a suite name and a simple
// regular expressions to be used on the full path of a test file
// in that test suite. If no selectors are explicitly given use
« no previous file with comments | « tools/testing/bin/jsshell.bat ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698