Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1101003002: Use package:test_reflective_loader instead of reflective_tests. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use package:test_reflective_loader instead of reflective_tests. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45367 Committed: https://code.google.com/p/dart/source/detail?r=45368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -418 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_hover_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_occurrences_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_outline_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/reanalyze_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 1 chunk +11 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/error_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_after_analysis_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_before_analysis_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/highlights_test.dart View 5 chunks +20 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/navigation_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/occurrences_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/outline_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/overrides_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/package_root_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/reanalyze_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_list_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/asynchrony_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/completion/get_suggestions_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/server/get_version_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/server/shutdown_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/server/status_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/operation/operation_queue_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 2 chunks +12 lines, -10 lines 0 comments Download
D pkg/analysis_server/test/reflective_tests.dart View 1 chunk +0 lines, -121 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/search/search_result_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/arglist_contributor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/combinator_contributor_test.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/common_usage_computer_test.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_manager_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart View 3 chunks +17 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/prefixed_element_contributor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/change_test.dart View 1 chunk +7 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/levenshtein_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/name_suggestion_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/sort_members_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/source_range_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/strings_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/index/local_index_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/codec_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/collection_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/split_store_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/temporary_folder_file_manager_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 3 chunks +11 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_label_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 4 chunks +8 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/source/optimizing_pub_package_map_provider_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 8 months ago (2015-04-22 20:23:39 UTC) #1
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-22 20:30:19 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 45367 (presubmit successful).
5 years, 8 months ago (2015-04-22 21:13:00 UTC) #3
scheglov
5 years, 8 months ago (2015-04-22 21:16:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45368 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698