Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart

Issue 1101003002: Use package:test_reflective_loader instead of reflective_tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
index 0fe8047c948128e9d3b4b0d5f0c3a4e3b596a143..77c43f03f2e9415d26eeb2cdd38a3793adfdc997 100644
--- a/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
@@ -7,14 +7,14 @@ library test.services.completion.dart.local;
import 'package:analysis_server/src/protocol_server.dart';
import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
import 'package:analysis_server/src/services/completion/local_reference_contributor.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
import 'package:unittest/unittest.dart';
-import '../../reflective_tests.dart';
import 'completion_test_util.dart';
main() {
groupSep = ' | ';
- runReflectiveTests(LocalReferenceContributorTest);
+ defineReflectiveTests(LocalReferenceContributorTest);
}
@reflectiveTest
@@ -149,21 +149,6 @@ class C extends B with M1, M2 {
contributor = new LocalReferenceContributor();
}
- test_missing_params_function() {
- addTestSource('int f1{} main(){f^}');
- expect(computeFast(), isTrue);
- }
-
- test_missing_params_method() {
- addTestSource('class C1{int f1{} main(){f^}}');
- expect(computeFast(), isTrue);
- }
-
- test_missing_params_constructor() {
- addTestSource('class C1{C1{} main(){C^}}');
- expect(computeFast(), isTrue);
- }
-
test_break_ignores_outer_functions_using_closure() {
addTestSource('''
void main() {
@@ -756,6 +741,21 @@ class B extends A {
expect(suggestion.hasNamedParameters, false);
}
+ test_missing_params_constructor() {
+ addTestSource('class C1{C1{} main(){C^}}');
+ expect(computeFast(), isTrue);
+ }
+
+ test_missing_params_function() {
+ addTestSource('int f1{} main(){f^}');
+ expect(computeFast(), isTrue);
+ }
+
+ test_missing_params_method() {
+ addTestSource('class C1{int f1{} main(){f^}}');
+ expect(computeFast(), isTrue);
+ }
+
test_overrides() {
addTestSource('''
class A {m() {}}

Powered by Google App Engine
This is Rietveld 408576698