Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart

Issue 1101003002: Use package:test_reflective_loader instead of reflective_tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart b/pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart
index 805a3f383507b61b86a39083f1d21ea64bb499da..11f3f8a141b2adc34c3f503dde795ee9f5c20170 100644
--- a/pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart
@@ -10,14 +10,14 @@ import 'package:analysis_server/src/protocol.dart' hide ElementKind;
import 'package:analysis_server/src/services/correction/status.dart';
import 'package:analysis_server/src/services/refactoring/refactoring.dart';
import 'package:analyzer/src/generated/element.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
import 'package:unittest/unittest.dart';
-import '../../reflective_tests.dart';
import 'abstract_refactoring.dart';
main() {
groupSep = ' | ';
- runReflectiveTests(ConvertMethodToGetterTest);
+ defineReflectiveTests(ConvertMethodToGetterTest);
}
@reflectiveTest
@@ -146,15 +146,6 @@ main() {
'Only methods without parameters can be converted to getters.');
}
- test_checkInitialConditions_returnTypeVoid() {
- indexTestUnit('''
-void test() {}
-''');
- _createRefactoring('test');
- // check conditions
- _assertInitialConditions_fatal('Cannot convert function returning void.');
- }
-
test_checkInitialConditions_localFunction() {
indexTestUnit('''
main() {
@@ -180,6 +171,15 @@ class A {
'Only class methods or top-level functions can be converted to getters.');
}
+ test_checkInitialConditions_returnTypeVoid() {
+ indexTestUnit('''
+void test() {}
+''');
+ _createRefactoring('test');
+ // check conditions
+ _assertInitialConditions_fatal('Cannot convert function returning void.');
+ }
+
Future _assertInitialConditions_fatal(String message) async {
RefactoringStatus status = await refactoring.checkInitialConditions();
assertRefactoringStatus(status, RefactoringProblemSeverity.FATAL,

Powered by Google App Engine
This is Rietveld 408576698