Issue 10996062: Use static final empty Modifier instead of null.

Issue 10996062: Use static final empty Modifier instead of null. (Closed)

Created:
8 years, 2 months ago by Johnni Winther

Modified:
8 years, 2 months ago

Reviewers:
ahe, floitsch, Lasse Reichstein Nielsen, ngeoffray

CC:
reviews_dartlang.org, ngeoffray, karlklose, floitsch, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use static final empty Modifier instead of null. Committed: https://code.google.com/p/dart/source/detail?r=13050

Patch Set 2 : Missing uses fixed. #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -47 lines)			Patch
M	lib/compiler/implementation/compile_time_constants.dart	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/backend.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1	9 chunks	+12 lines, -10 lines	0 comments	Download
M	lib/compiler/implementation/js_backend/emitter.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View		4 chunks	+4 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View		3 chunks	+8 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	lib/compiler/implementation/tree/nodes.dart	View		4 chunks	+11 lines, -4 lines	2 comments	Download
M	lib/compiler/implementation/tree/unparser.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View		4 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

lgtm. http://codereview.chromium.org/10996062/diff/1001/lib/compiler/implementation/tree/nodes.dart File lib/compiler/implementation/tree/nodes.dart (right): http://codereview.chromium.org/10996062/diff/1001/lib/compiler/implementation/tree/nodes.dart#newcode1101 lib/compiler/implementation/tree/nodes.dart:1101: * Pseudo-constant for empty modifiers. Use this instead ...

8 years, 2 months ago (2012-10-01 09:02:59 UTC) #4

Johnni Winther

8 years, 2 months ago (2012-10-01 09:12:11 UTC) #5

http://codereview.chromium.org/10996062/diff/1001/lib/compiler/implementation...
File lib/compiler/implementation/tree/nodes.dart (right):

http://codereview.chromium.org/10996062/diff/1001/lib/compiler/implementation...
lib/compiler/implementation/tree/nodes.dart:1101: * Pseudo-constant for empty
modifiers. Use this instead of null.
On 2012/10/01 09:02:59, floitsch wrote:
> Remove "Use this instead of null".

Why?

Expand Messages | Collapse Messages