Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart

Issue 10996062: Use static final empty Modifier instead of null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Missing uses fixed. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
diff --git a/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart b/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
index 27494e06a71d4f9c4e0e480a3fdaeeb9b6914de7..c374e56146b75afbbb98beb0defa21da82487d38 100644
--- a/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
+++ b/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
@@ -754,8 +754,7 @@ class Dart2JsInterfaceMirror extends Dart2JsObjectMirror
bool get isInterface => _class.isInterface();
- bool get isAbstract =>
- _class.modifiers !== null && _class.modifiers.isAbstract();
+ bool get isAbstract => _class.modifiers.isAbstract();
bool get isPrivate => _isPrivate(simpleName);
@@ -1253,13 +1252,12 @@ class Dart2JsMethodMirror extends Dart2JsElementMirror
// canonical name is TypeName
_canonicalName = _name;
}
- if (_function.modifiers !== null && _function.modifiers.isConst()) {
+ if (_function.modifiers.isConst()) {
_kind = Dart2JsMethodKind.CONST;
} else {
_kind = Dart2JsMethodKind.CONSTRUCTOR;
}
- } else if (_function.modifiers !== null &&
- _function.modifiers.isFactory()) {
+ } else if (_function.modifiers.isFactory()) {
_kind = Dart2JsMethodKind.FACTORY;
_constructorName = '';
int dollarPos = _name.indexOf('\$');
@@ -1310,8 +1308,7 @@ class Dart2JsMethodMirror extends Dart2JsElementMirror
bool get isPrivate => _isPrivate(simpleName);
- bool get isStatic =>
- _function.modifiers !== null && _function.modifiers.isStatic();
+ bool get isStatic => _function.modifiers.isStatic();
List<ParameterMirror> get parameters {
return _parametersFromFunctionSignature(system, this,
@@ -1322,8 +1319,7 @@ class Dart2JsMethodMirror extends Dart2JsElementMirror
system, _function.computeSignature(system.compiler).returnType,
system.compiler.types.dynamicType);
- bool get isAbstract =>
- _function.modifiers !== null && _function.modifiers.isAbstract();
+ bool get isAbstract => _function.modifiers.isAbstract();
bool get isConst => _kind == Dart2JsMethodKind.CONST;
« lib/compiler/implementation/tree/nodes.dart ('K') | « lib/compiler/implementation/tree/unparser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698