lib/compiler/implementation/ssa/builder.dart - Issue 10996062: Use static final empty Modifier instead of null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10996062: Use static final empty Modifier instead of null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Missing uses fixed. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/ssa/builder.dart

diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart

index 5e58525d4889c828a1975eb61779ab63eb1b4e5c..e2b17147055617eeabdfe61f0faf0944a0664439 100644

--- a/lib/compiler/implementation/ssa/builder.dart

+++ b/lib/compiler/implementation/ssa/builder.dart

@@ -915,7 +915,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

assert(invariant(functionElement, functionElement.isImplementation));

FunctionExpression function = functionElement.parseNode(compiler);

assert(function !== null);

- assert(function.modifiers === null || !function.modifiers.isExternal());

+ assert(!function.modifiers.isExternal());

assert(elements[function] !== null);

openFunction(functionElement, function);

function.body.accept(this);