Reapply change to hide VM-only List implementation classes.

Reapply change to hide VM-only List implementation classes.

The performance issue was that I had not updated the method
recognizer.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=13003

[Mads Ager (google), 2012-09-27 15:17:15]

There we go, updated method recognizer as well as intrinsifier. The performance
problem was that we no longer recognized the length getter on lists. The method
recognizer patch is patch set two of this upload.

[Ivan Posva, 2012-09-28 04:56:10]

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/common.dart
File runtime/bin/common.dart (right):

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/common.dart#ne...
runtime/bin/common.dart:54: bool _isBuiltinList(List buffer) native
"Common_IsBuiltinList";
You can do this now without reaching into native! You can check if
buffer.runtimeType is equal to (const [1]).runtimeType or to (new
List(1)).runtimeType. Ideally you would cache the two values in statics.

[Ivan Posva, 2012-09-28 04:57:46]

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/common.dart
File runtime/bin/common.dart (right):

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/common.dart#ne...
runtime/bin/common.dart:54: bool _isBuiltinList(List buffer) native
"Common_IsBuiltinList";
On 2012/09/28 04:56:10, Ivan Posva wrote:
> You can do this now without reaching into native! You can check if
> buffer.runtimeType is equal to (const [1]).runtimeType or to (new
> List(1)).runtimeType. Ideally you would cache the two values in statics.

Scratch this. List is parameterized and thus "List<int> != List". Oh well...

[Mads Ager (google), 2012-09-28 10:14:20]

Soren, you reviewed most of this before. Could you have a look at patch set two
and three?

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/common.dart
File runtime/bin/common.dart (right):

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/common.dart#ne...
runtime/bin/common.dart:54: bool _isBuiltinList(List buffer) native
"Common_IsBuiltinList";
On 2012/09/28 04:57:46, Ivan Posva wrote:
> On 2012/09/28 04:56:10, Ivan Posva wrote:
> > You can do this now without reaching into native! You can check if
> > buffer.runtimeType is equal to (const [1]).runtimeType or to (new
> > List(1)).runtimeType. Ideally you would cache the two values in statics.
> 
> Scratch this. List is parameterized and thus "List<int> != List". Oh well...

Yeah, unfortunately. Luckily there was plenty of room for improvement in the
implementation of isBuiltinList. I now cache the class pointers in persistent
handles in the isolate data in the standalone binary. That should make the check
a lot cheaper.

[Søren Gjesse, 2012-09-28 10:39:43]

LGTM for patch set #2 and #3

[Ivan Posva, 2012-09-28 16:26:09]

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/socket_impl.da...
runtime/bin/socket_impl.dart:407: var fastBuffer =
_ensureFastAndSerializableBuffer(buffer, offset, bytes);
Returning a List with two elements for buffer and offset instead of an object
with real properties is freaky and really hard to understand.

https://codereview.chromium.org/10990083/diff/1001/runtime/lib/array_patch.dart
File runtime/lib/array_patch.dart (right):

https://codereview.chromium.org/10990083/diff/1001/runtime/lib/array_patch.da...
runtime/lib/array_patch.dart:5: // Note that optimizing compiler depends on the
algorithm which
that optimizing compiler -> that the optimizing compiler

https://codereview.chromium.org/10990083/diff/1001/runtime/vm/intrinsifier.h
File runtime/vm/intrinsifier.h (right):

https://codereview.chromium.org/10990083/diff/1001/runtime/vm/intrinsifier.h#...
runtime/vm/intrinsifier.h:59: V(_GrowableObjectArray,                           
                          \
This should definitely fit on one line, especially if it did before.

[Mads Ager (google), 2012-09-29 11:54:53]

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

https://codereview.chromium.org/10990083/diff/1001/runtime/bin/socket_impl.da...
runtime/bin/socket_impl.dart:407: var fastBuffer =
_ensureFastAndSerializableBuffer(buffer, offset, bytes);
On 2012/09/28 16:26:09, Ivan Posva wrote:
> Returning a List with two elements for buffer and offset instead of an object
> with real properties is freaky and really hard to understand.

Agreed, that is not pretty. I have a change up for review to clean that up along
with a bunch of other stuff in file implementation that was left over from a
previous version of the file implementation.

https://codereview.chromium.org/10990083/diff/1001/runtime/lib/array_patch.dart
File runtime/lib/array_patch.dart (right):

https://codereview.chromium.org/10990083/diff/1001/runtime/lib/array_patch.da...
runtime/lib/array_patch.dart:5: // Note that optimizing compiler depends on the
algorithm which
On 2012/09/28 16:26:09, Ivan Posva wrote:
> that optimizing compiler -> that the optimizing compiler

Done in a separate patch sent to your for review.

https://codereview.chromium.org/10990083/diff/1001/runtime/vm/intrinsifier.h
File runtime/vm/intrinsifier.h (right):

https://codereview.chromium.org/10990083/diff/1001/runtime/vm/intrinsifier.h#...
runtime/vm/intrinsifier.h:59: V(_GrowableObjectArray,                           
                          \
On 2012/09/28 16:26:09, Ivan Posva wrote:
> This should definitely fit on one line, especially if it did before.

Yes, it does now, thanks. It didn't when I followed the (broken)
_Double.fromInteger style and had _GrowableObjectArray.fromObjectArray. Fixed in
a separate patch sent out to you for review. Thanks!