Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Side by Side Diff: runtime/vm/dart_api_impl.cc

Issue 10990083: Reapply change to hide VM-only List implementation classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix dart:io perf regression. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/lib/string_base.dart ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "include/dart_api.h" 5 #include "include/dart_api.h"
6 6
7 #include "vm/bigint_operations.h" 7 #include "vm/bigint_operations.h"
8 #include "vm/class_finalizer.h" 8 #include "vm/class_finalizer.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart.h" 10 #include "vm/dart.h"
(...skipping 1954 matching lines...) Expand 10 before | Expand all | Expand 10 after
1965 instance, function, args, kNoArgumentNames)); 1965 instance, function, args, kNoArgumentNames));
1966 } 1966 }
1967 } 1967 }
1968 return Api::NewError("Object does not implement the 'List' interface"); 1968 return Api::NewError("Object does not implement the 'List' interface");
1969 } 1969 }
1970 } 1970 }
1971 1971
1972 1972
1973 // TODO(hpayer): value should always be smaller then 0xff. Add error handling. 1973 // TODO(hpayer): value should always be smaller then 0xff. Add error handling.
1974 #define GET_LIST_ELEMENT_AS_BYTES(isolate, type, obj, native_array, offset, \ 1974 #define GET_LIST_ELEMENT_AS_BYTES(isolate, type, obj, native_array, offset, \
1975 length) \ 1975 length) \
1976 const type& array = type::Cast(obj); \ 1976 const type& array = type::Cast(obj); \
1977 if (Utils::RangeCheck(offset, length, array.Length())) { \ 1977 if (Utils::RangeCheck(offset, length, array.Length())) { \
1978 Object& element = Object::Handle(isolate); \ 1978 Object& element = Object::Handle(isolate); \
1979 for (int i = 0; i < length; i++) { \ 1979 for (int i = 0; i < length; i++) { \
1980 element = array.At(offset + i); \ 1980 element = array.At(offset + i); \
1981 if (!element.IsInteger()) { \ 1981 if (!element.IsInteger()) { \
1982 return Api::NewError("%s expects the argument 'list' to be " \ 1982 return Api::NewError("%s expects the argument 'list' to be " \
1983 "a List of int", CURRENT_FUNC); \ 1983 "a List of int", CURRENT_FUNC); \
1984 } \ 1984 } \
1985 const Integer& integer = Integer::Cast(element); \ 1985 const Integer& integer = Integer::Cast(element); \
(...skipping 2505 matching lines...) Expand 10 before | Expand all | Expand 10 after
4491 } 4491 }
4492 { 4492 {
4493 NoGCScope no_gc; 4493 NoGCScope no_gc;
4494 RawObject* raw_obj = obj.raw(); 4494 RawObject* raw_obj = obj.raw();
4495 isolate->heap()->SetPeer(raw_obj, peer); 4495 isolate->heap()->SetPeer(raw_obj, peer);
4496 } 4496 }
4497 return Api::Success(isolate); 4497 return Api::Success(isolate);
4498 } 4498 }
4499 4499
4500 } // namespace dart 4500 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/lib/string_base.dart ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698