Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 10990083: Reapply change to hide VM-only List implementation classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix dart:io perf regression. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier.cc ('k') | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_ia32.cc
diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc
index 8bc661e7b89836c0735ccef516aa2c8e879db236..11db7d79c1c84092db23cedf5eed352efd68a74a 100644
--- a/runtime/vm/intrinsifier_ia32.cc
+++ b/runtime/vm/intrinsifier_ia32.cc
@@ -174,9 +174,10 @@ bool Intrinsifier::ImmutableArray_getIndexed(Assembler* assembler) {
static intptr_t ComputeObjectArrayTypeArgumentsOffset() {
- const String& class_name = String::Handle(Symbols::New("ObjectArray"));
- const Class& cls = Class::Handle(
- Library::Handle(Library::CoreImplLibrary()).LookupClass(class_name));
+ const String& class_name = String::Handle(Symbols::New("_ObjectArray"));
+ const Library& coreimpl_lib = Library::Handle(Library::CoreImplLibrary());
+ const Class& cls =
+ Class::Handle(coreimpl_lib.LookupClassAllowPrivate(class_name));
ASSERT(!cls.IsNull());
ASSERT(cls.HasTypeArguments());
ASSERT(cls.NumTypeArguments() == 1);
@@ -251,8 +252,9 @@ static intptr_t GetOffsetForField(const char* class_name_p,
const char* field_name_p) {
const String& class_name = String::Handle(Symbols::New(class_name_p));
const String& field_name = String::Handle(Symbols::New(field_name_p));
- const Class& cls = Class::Handle(Library::Handle(
- Library::CoreImplLibrary()).LookupClass(class_name));
+ const Library& coreimpl_lib = Library::Handle(Library::CoreImplLibrary());
+ const Class& cls =
+ Class::Handle(coreimpl_lib.LookupClassAllowPrivate(class_name));
ASSERT(!cls.IsNull());
const Field& field = Field::ZoneHandle(cls.LookupInstanceField(field_name));
ASSERT(!field.IsNull());
@@ -1290,7 +1292,7 @@ bool Intrinsifier::Object_equal(Assembler* assembler) {
}
-static const char* kFixedSizeArrayIteratorClassName = "FixedSizeArrayIterator";
+static const char* kFixedSizeArrayIteratorClassName = "_FixedSizeArrayIterator";
// Class 'FixedSizeArrayIterator':
« no previous file with comments | « runtime/vm/intrinsifier.cc ('k') | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698