First step toward fixing cascades (issue 5062)

First step toward fixing cascades (issue 5062)
Committed: https://code.google.com/p/dart/source/detail?r=13023

[Brian Wilkerson, 2012-09-27 22:25:02]

This doesn't fix 5146, but I wanted to get your feedback before going further.

[scheglov, 2012-09-27 22:38:43]

lgtm

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/ast/DartCascadeExpression.java
(right):

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/ast/DartCascadeExpression.java:35:
private NodeList<DartExpression> cascadeSections = new
NodeList<DartExpression>(this);
Just "sections"?
We don't use "invocationArguments" or "constructorArguments" or "cascadeTarget".

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
File
compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java
(right):

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java:15:
private boolean isCascade;
Can you give example of cascade here?

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java:33:
public DartExpression getRealTarget() {
We could put (at least implementation) into ASTNodes.

[Brian Wilkerson, 2012-09-28 15:54:39]

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/ast/DartCascadeExpression.java
(right):

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/ast/DartCascadeExpression.java:35:
private NodeList<DartExpression> cascadeSections = new
NodeList<DartExpression>(this);
> Just "sections"?

I thought about that, but it seemed kind of generic. I really don't like either
name and think we should have better terminology, but that's how the grammar
refers to them. I can change it if you feel strongly about it.

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
File
compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java
(right):

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java:15:
private boolean isCascade;
> Can you give example of cascade here?

Not off the top of my head. I'll double check and make sure that this is
necessary and back it out in a later CL if it isn't.

http://codereview.chromium.org/10984081/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java:33:
public DartExpression getRealTarget() {
> We could put (at least implementation) into ASTNodes.

Let's discuss this off-line.