Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java

Issue 10984081: First step toward fixing cascades (issue 5062) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java
===================================================================
--- compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java (revision 12980)
+++ compiler/java/com/google/dart/compiler/ast/DartFunctionObjectInvocation.java (working copy)
@@ -12,11 +12,17 @@
public class DartFunctionObjectInvocation extends DartInvocation {
private DartExpression target;
+ private boolean isCascade;
scheglov 2012/09/27 22:38:43 Can you give example of cascade here?
Brian Wilkerson 2012/09/28 15:54:39 Not off the top of my head. I'll double check and
- public DartFunctionObjectInvocation(DartExpression target,
+ public DartFunctionObjectInvocation(DartExpression target, List<DartExpression> args) {
+ this(target, false, args);
+ }
+
+ public DartFunctionObjectInvocation(DartExpression target, boolean isCascade,
List<DartExpression> args) {
super(args);
this.target = becomeParentOf(target);
+ this.isCascade = isCascade;
}
@Override
@@ -24,6 +30,24 @@
return target;
}
+ public DartExpression getRealTarget() {
scheglov 2012/09/27 22:38:43 We could put (at least implementation) into ASTNod
Brian Wilkerson 2012/09/28 15:54:39 Let's discuss this off-line.
+ if (isCascade) {
+ DartNode ancestor = getParent();
+ while (!(ancestor instanceof DartCascadeExpression)) {
+ if (ancestor == null) {
+ return target;
+ }
+ ancestor = ancestor.getParent();
+ }
+ return ((DartCascadeExpression) ancestor).getTarget();
+ }
+ return target;
+ }
+
+ public boolean isCascade() {
+ return isCascade;
+ }
+
@Override
public void visitChildren(ASTVisitor<?> visitor) {
safelyVisitChild(target, visitor);

Powered by Google App Engine
This is Rietveld 408576698