Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java

Issue 10984081: First step toward fixing cascades (issue 5062) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java
===================================================================
--- compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java (revision 12980)
+++ compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java (working copy)
@@ -684,10 +684,18 @@
}
@Override
+ public Void visitCascadeExpression(DartCascadeExpression x) {
+ accept(x.getTarget());
+ acceptList(x.getCascadeSections());
+ return null;
+ }
+
+ @Override
public Void visitArrayAccess(DartArrayAccess x) {
- accept(x.getTarget());
if (x.isCascade()) {
p("..");
+ } else {
+ accept(x.getTarget());
}
p("[");
accept(x.getKey());
@@ -710,17 +718,19 @@
@Override
public Void visitFunctionObjectInvocation(DartFunctionObjectInvocation x) {
- accept(x.getTarget());
+ if (!x.isCascade()) {
+ accept(x.getTarget());
+ }
pArgs(x.getArguments());
return null;
}
@Override
public Void visitMethodInvocation(DartMethodInvocation x) {
- accept(x.getTarget());
if (x.isCascade()) {
p("..");
} else {
+ accept(x.getTarget());
p(".");
}
accept(x.getFunctionName());

Powered by Google App Engine
This is Rietveld 408576698