Add an "onPlatform" parameter to test() and group().

Add an "onPlatform" parameter to test() and group().

This allows platform-specific metadata to be declared.

See #75

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/16f8247a8e5f84a78a354bf158cd86dff42ecacb

[kevmoo, 2015-04-20 22:42:30]

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/invoker.dart
File lib/src/backend/invoker.dart (right):

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/invoker.dar...
lib/src/backend/invoker.dart:46: Test change({String name, Metadata metadata}) {
docs?

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/metadata.dart
File lib/src/backend/metadata.dart (right):

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/metadata.da...
lib/src/backend/metadata.dart:152: Metadata forPlatform(TestPlatform platform,
{OperatingSystem os}) {
TestPlatform and OperatingSystem are not defined

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/metadata.da...
lib/src/backend/metadata.dart:154:
test.metadata.onPlatform.forEach((platformSelector, platformMetadata) {
test is not defined

https://codereview.chromium.org/1097183003/diff/1/lib/src/runner/vm/isolate_l...
File lib/src/runner/vm/isolate_listener.dart (right):

https://codereview.chromium.org/1097183003/diff/1/lib/src/runner/vm/isolate_l...
lib/src/runner/vm/isolate_listener.dart:12: import
'../../backend/operating_system.dart';
unused import

[nweiz, 2015-04-20 22:57:49]

Code review changes

[nweiz, 2015-04-20 22:57:53]

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/invoker.dart
File lib/src/backend/invoker.dart (right):

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/invoker.dar...
lib/src/backend/invoker.dart:46: Test change({String name, Metadata metadata}) {
On 2015/04/20 22:42:30, kevmoo wrote:
> docs?

Done (in Test).

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/metadata.dart
File lib/src/backend/metadata.dart (right):

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/metadata.da...
lib/src/backend/metadata.dart:152: Metadata forPlatform(TestPlatform platform,
{OperatingSystem os}) {
On 2015/04/20 22:42:30, kevmoo wrote:
> TestPlatform and OperatingSystem are not defined

Done.

https://codereview.chromium.org/1097183003/diff/1/lib/src/backend/metadata.da...
lib/src/backend/metadata.dart:154:
test.metadata.onPlatform.forEach((platformSelector, platformMetadata) {
On 2015/04/20 22:42:30, kevmoo wrote:
> test is not defined

Done.

https://codereview.chromium.org/1097183003/diff/1/lib/src/runner/vm/isolate_l...
File lib/src/runner/vm/isolate_listener.dart (right):

https://codereview.chromium.org/1097183003/diff/1/lib/src/runner/vm/isolate_l...
lib/src/runner/vm/isolate_listener.dart:12: import
'../../backend/operating_system.dart';
On 2015/04/20 22:42:30, kevmoo wrote:
> unused import

Done.

[nweiz, 2015-04-21 00:35:57]

PTAL

[kevmoo, 2015-04-21 00:45:10]

On 2015/04/21 00:35:57, nweiz wrote:
> PTAL

"1" vs "one"

00:05 +12 -1: test/runner/runner_test.dart: fails gracefully if an annotation's
structure is invalid
  Expected: (contains '-1: load error' and contains '  Failed to load
"test.dart":\n'
    '  Error on line 1, column 8: TestOn takes one argument.\n'
    '  @TestOn()\n'
    '         ^^\n'
    '')
    Actual: '\r00:00 +0: load error                                             
                                  \r00:00 +0 -1: load error                     
                                                       \n'
    '  Failed to load "test.dart":\n'
    '  Error on line 1, column 8: TestOn takes 1 argument.\n'
    '  @TestOn()\n'
    '         ^^\n'
    '\r00:00 +0 -1: Some tests failed.                                          
                          \n'
    ''

  package:test                        expect
  test/runner/runner_test.dart 150:7  main.<fn>.<fn>

[nweiz, 2015-04-21 01:18:26]

On 2015/04/21 00:45:10, kevmoo wrote:
> On 2015/04/21 00:35:57, nweiz wrote:
> > PTAL
> 
> "1" vs "one"
> 
> 00:05 +12 -1: test/runner/runner_test.dart: fails gracefully if an
annotation's
> structure is invalid
>   Expected: (contains '-1: load error' and contains '  Failed to load
> "test.dart":\n'
>     '  Error on line 1, column 8: TestOn takes one argument.\n'
>     '  @TestOn()\n'
>     '         ^^\n'
>     '')
>     Actual: '\r00:00 +0: load error                                           
 
>                                   \r00:00 +0 -1: load error                   
 
>                                                        \n'
>     '  Failed to load "test.dart":\n'
>     '  Error on line 1, column 8: TestOn takes 1 argument.\n'
>     '  @TestOn()\n'
>     '         ^^\n'
>     '\r00:00 +0 -1: Some tests failed.                                        
 
>                           \n'
>     ''
> 
>   package:test                        expect
>   test/runner/runner_test.dart 150:7  main.<fn>.<fn>

That failure isn't specific to this CL.

[kevmoo, 2015-04-21 01:29:59]

LGTM modulo nit

https://codereview.chromium.org/1097183003/diff/60001/lib/src/runner/browser/...
File lib/src/runner/browser/browser_manager.dart (right):

https://codereview.chromium.org/1097183003/diff/60001/lib/src/runner/browser/...
lib/src/runner/browser/browser_manager.dart:27: TestPlatform browser;
final

[nweiz, 2015-04-21 02:19:07]

Code review changes

[nweiz, 2015-04-21 02:19:12]

https://codereview.chromium.org/1097183003/diff/60001/lib/src/runner/browser/...
File lib/src/runner/browser/browser_manager.dart (right):

https://codereview.chromium.org/1097183003/diff/60001/lib/src/runner/browser/...
lib/src/runner/browser/browser_manager.dart:27: TestPlatform browser;
On 2015/04/21 01:29:59, kevmoo wrote:
> final

Done.

[nweiz, 2015-04-21 02:19:21]

Committed patchset #5 (id:80001) manually as
16f8247a8e5f84a78a354bf158cd86dff42ecacb (presubmit successful).