Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: lib/src/runner/browser/iframe_test.dart

Issue 1097183003: Add an "onPlatform" parameter to test() and group(). (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/runner/browser/iframe_listener.dart ('k') | lib/src/runner/browser/server.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.runner.browser.iframe_test; 5 library test.runner.browser.iframe_test;
6 6
7 import '../../backend/live_test.dart'; 7 import '../../backend/live_test.dart';
8 import '../../backend/live_test_controller.dart'; 8 import '../../backend/live_test_controller.dart';
9 import '../../backend/metadata.dart'; 9 import '../../backend/metadata.dart';
10 import '../../backend/state.dart'; 10 import '../../backend/state.dart';
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 }); 53 });
54 }, () { 54 }, () {
55 // Ignore all future messages from the test and complete it immediately. 55 // Ignore all future messages from the test and complete it immediately.
56 // We don't need to tell it to run its tear-down because there's nothing a 56 // We don't need to tell it to run its tear-down because there's nothing a
57 // browser test needs to clean up on the file system anyway. 57 // browser test needs to clean up on the file system anyway.
58 testChannel.sink.close(); 58 testChannel.sink.close();
59 if (!controller.completer.isCompleted) controller.completer.complete(); 59 if (!controller.completer.isCompleted) controller.completer.complete();
60 }); 60 });
61 return controller.liveTest; 61 return controller.liveTest;
62 } 62 }
63
64 Test change({String name, Metadata metadata}) {
65 if (name == null) name = this.name;
66 if (metadata == null) metadata = this.metadata;
67 return new IframeTest(name, metadata, _channel);
68 }
63 } 69 }
OLDNEW
« no previous file with comments | « lib/src/runner/browser/iframe_listener.dart ('k') | lib/src/runner/browser/server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698