Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: lib/src/runner/browser/iframe_listener.dart

Issue 1097183003: Add an "onPlatform" parameter to test() and group(). (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/browser_manager.dart ('k') | lib/src/runner/browser/iframe_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/iframe_listener.dart
diff --git a/lib/src/runner/browser/iframe_listener.dart b/lib/src/runner/browser/iframe_listener.dart
index 468e3accdf251220d7e30cf0976864790fe07eb7..b345f3795adecb5bf59702faa12c4f8367b11281 100644
--- a/lib/src/runner/browser/iframe_listener.dart
+++ b/lib/src/runner/browser/iframe_listener.dart
@@ -12,6 +12,7 @@ import '../../backend/declarer.dart';
import '../../backend/metadata.dart';
import '../../backend/suite.dart';
import '../../backend/test.dart';
+import '../../backend/test_platform.dart';
import '../../util/multi_channel.dart';
import '../../util/remote_exception.dart';
import '../../utils.dart';
@@ -66,12 +67,13 @@ class IframeListener {
}
var url = Uri.parse(window.location.href);
- var metadata = url.hasFragment
- ? new Metadata.deserialize(JSON.decode(Uri.decodeFull(url.fragment)))
- : new Metadata();
+ var message = JSON.decode(Uri.decodeFull(url.fragment));
+ var metadata = new Metadata.deserialize(message['metadata']);
+ var browser = TestPlatform.find(message['browser']);
- new IframeListener._(new Suite(declarer.tests, metadata: metadata))
- ._listen(channel);
+ var suite = new Suite(declarer.tests, metadata: metadata)
+ .forPlatform(browser);
+ new IframeListener._(suite)._listen(channel);
}
/// Constructs a [MultiChannel] wrapping the `postMessage` communication with
« no previous file with comments | « lib/src/runner/browser/browser_manager.dart ('k') | lib/src/runner/browser/iframe_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698