Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 109703008: Fix error messages for disjoint version errors. (Closed)

Created:
7 years ago by Bob Nystrom
Modified:
7 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix error messages for disjoint version errors. BUG=https://code.google.com/p/dart/issues/detail?id=15474 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31151

Patch Set 1 #

Patch Set 2 : Revise barback error patch after merging it with this one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -29 lines) Patch
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 1 4 chunks +19 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/version_solver.dart View 1 1 chunk +10 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart View 1 3 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/version_solver_test.dart View 11 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
There were actually a few things wrong here: 1. On a disjoint constraint exception, we ...
7 years ago (2013-12-13 21:17:54 UTC) #1
nweiz
lgtm
7 years ago (2013-12-13 23:02:09 UTC) #2
Bob Nystrom
This has the changes from the barback error patch now. PTAL.
7 years ago (2013-12-14 00:07:57 UTC) #3
nweiz
> I can do this if you really want me to, but it will be ...
7 years ago (2013-12-14 00:21:54 UTC) #4
Bob Nystrom
7 years ago (2013-12-14 00:24:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r31151 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698