Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart

Issue 109703008: Fix error messages for disjoint version errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise barback error patch after merging it with this one. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart
diff --git a/sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart b/sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart
index 29218b008d3060c97b921c9a2b044d4987385332..4d0074fbeb3a248aca4341821dbd31da73d41267 100644
--- a/sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart
+++ b/sdk/lib/_internal/pub/test/implicit_barback_dependency_test.dart
@@ -105,7 +105,7 @@ main() {
}).validate();
});
- integration("include pub in the error if a solve failed because there "
+ integration("includes pub in the error if a solve failed because there "
"is no version available", () {
servePackages([
packageMap("barback", previous)
@@ -116,10 +116,10 @@ main() {
pubGet(error: """
Package 'barback' has no versions that match >=$current <$max derived from:
- 'myapp' depends on version any
-- 'pub' depends on version >=$current <$max""");
+- pub itself depends on version >=$current <$max""");
});
- integration("include pub in the error if a solve failed because there "
+ integration("includes pub in the error if a solve failed because there "
"is a disjoint constraint", () {
servePackages([
packageMap("barback", current)
@@ -128,8 +128,8 @@ Package 'barback' has no versions that match >=$current <$max derived from:
d.appDir({"barback": previous}).create();
pubGet(error: """
-Incompatible version constraints on 'myapp':
+Incompatible version constraints on 'barback':
- 'myapp' depends on version $previous
-- 'pub' depends on version >=$current <$max""");
+- pub itself depends on version >=$current <$max""");
});
}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/solver/version_solver.dart ('k') | sdk/lib/_internal/pub/test/version_solver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698