Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: sdk/lib/_internal/pub/lib/src/solver/version_solver.dart

Issue 109703008: Fix error messages for disjoint version errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise barback error patch after merging it with this one. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
diff --git a/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart b/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
index 8d78871cfa22f07df96f34cf53de7727ad2472e1..d77eb824c8f9864cfa258149fda5c0958d0d6f5e 100644
--- a/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
+++ b/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
@@ -244,8 +244,16 @@ abstract class SolveFailure implements ApplicationException {
var names = ordered(map.keys);
- buffer.writeAll(names.map(
- (name) => "- '$name' ${_describeDependency(map[name])}"), '\n');
+ for (var name in names) {
+ buffer.writeln();
+ buffer.write("- ");
+ if (name == "pub itself") {
+ buffer.write(name);
+ } else {
+ buffer.write("'$name'");
+ }
+ buffer.write(" ${_describeDependency(map[name])}");
+ }
return buffer.toString();
}

Powered by Google App Engine
This is Rietveld 408576698