Issue 10943012: Issue 5153. Setter should not conflict with method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10943012: Issue 5153. Setter should not conflict with method (Closed)

Created:
8 years, 3 months ago by scheglov

Modified:
8 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 5153. Setter should not conflict with method http://code.google.com/p/dart/issues/detail?id=5153 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12528

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -47 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/AbstractNodeElement.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java	View	4 chunks	+40 lines, -1 line	1 comment	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java	View	2 chunks	+20 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java	View	9 chunks	+29 lines, -27 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	7 chunks	+39 lines, -6 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	tests/language/language.status	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 3 months ago (2012-09-18 17:26:42 UTC) #2

You're right, this is really ugly, and I don't have any idea whether there are
missing changes that need to be changed, but as far as what's there, LGTM.

https://codereview.chromium.org/10943012/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java (right):

https://codereview.chromium.org/10943012/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java:447: element
= scope.findElement(library, "setter" + name);
Should there be a space here? Perhaps we could create a constant to avoid errors
like this.

Expand Messages | Collapse Messages