compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java - Issue 10943012: Issue 5153. Setter should not conflict with method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java

Issue 10943012: Issue 5153. Setter should not conflict with method (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/AbstractNodeElement.java ('k') | compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java » ('j') | compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java b/compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java

index 2ef64ccc32bb4bed8e6673fdb164faee64331f27..4ec338c3d409d0def21820e8f21618d1875bca88 100644

--- a/compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java

+++ b/compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java

@@ -5,8 +5,8 @@

package com.google.dart.compiler.resolver;

import com.google.dart.compiler.ast.DartField;

-import com.google.dart.compiler.ast.DartObsoleteMetadata;

import com.google.dart.compiler.ast.DartNode;

+import com.google.dart.compiler.ast.DartObsoleteMetadata;

import com.google.dart.compiler.ast.Modifiers;

import com.google.dart.compiler.common.SourceInfo;

import com.google.dart.compiler.type.Type;

@@ -80,7 +80,7 @@ class FieldElementImplementation extends AbstractNodeElement implements FieldEle

Modifiers modifiers) {

return new FieldElementImplementation(node,

node.getName().getSourceInfo(),

- node.getName().getName(),

+ (node.getAccessor() != null && node.getAccessor().getModifiers().isSetter() ? "setter " : "") + node.getName().getName(),

holder,

metadata,

modifiers);