compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java - Issue 10943012: Issue 5153. Setter should not conflict with method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java

Issue 10943012: Issue 5153. Setter should not conflict with method (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java ('K') | « compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java ('k') | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java

diff --git a/compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java b/compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java

index 33dbefd1e9ef0fef695d4097f7f4d91b867492be..a7ab8d64ab094c2dfa186ad53fc4e5eef1289e30 100644

--- a/compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java

+++ b/compiler/java/com/google/dart/compiler/type/InterfaceTypeImplementation.java

@@ -10,6 +10,7 @@ import com.google.dart.compiler.resolver.ElementKind;

import com.google.dart.compiler.resolver.Elements;

import com.google.dart.compiler.resolver.FieldElement;

import com.google.dart.compiler.resolver.MethodElement;

+import com.google.dart.compiler.util.apache.StringUtils;

import java.util.ArrayList;

import java.util.Arrays;

@@ -179,6 +180,9 @@ class InterfaceTypeImplementation extends AbstractType implements InterfaceType

if (setter == null) {

setter = Elements.lookupFieldElementSetter(holder.getElement(), member.getName());

if (setter == null) {

+ setter = Elements.lookupFieldElementSetter(holder.getElement(), "setter " + member.getName());

+ }

+ if (setter == null) {

return null;

}

@@ -200,7 +204,9 @@ class InterfaceTypeImplementation extends AbstractType implements InterfaceType

FieldElement field = (FieldElement) element;

MethodElement getter = field.getGetter();

if (getter == null) {

- getter = Elements.lookupFieldElementGetter(holder.getElement(), member.getName());

+ String name = member.getName();

+ name = StringUtils.stripStart(name, "setter ");

+ getter = Elements.lookupFieldElementGetter(holder.getElement(), name);

if (getter == null) {

return null;

}