Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10918260: Issue 5044. Keep FieldElement as Element for field access (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 5044. Keep FieldElement as Element for field access http://code.google.com/p/dart/issues/detail?id=5044 Move inGetterContext() and inSetterContext() from Elements to ASTNodes. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -180 lines) Patch
M compiler/java/com/google/dart/compiler/ast/ASTNodes.java View 3 chunks +60 lines, -16 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 4 chunks +0 lines, -60 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 2 chunks +5 lines, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 5 chunks +6 lines, -10 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 4 chunks +58 lines, -36 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/contributor/IndexContributor.java View 5 chunks +23 lines, -38 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/search/SearchEngineImpl.java View 1 chunk +8 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java View 2 chunks +20 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodAnalyzer.java View 2 chunks +1 line, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodRefactoring.java View 2 chunks +1 line, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/InlineLocalRefactoring.java View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 3 months ago (2012-09-15 20:03:17 UTC) #1
Brian Wilkerson
8 years, 3 months ago (2012-09-17 13:08:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698