Issue 5044. Keep FieldElement as Element for field access

compiler/java/com/google/dart/compiler/resolver/Resolver.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.resolver;
 
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Sets;
 import com.google.dart.compiler.DartCompilationPhase;
 import com.google.dart.compiler.DartCompilerContext;
 import com.google.dart.compiler.ErrorCode;
+import com.google.dart.compiler.ast.ASTNodes;
 import com.google.dart.compiler.ast.ASTVisitor;
 import com.google.dart.compiler.ast.DartArrayLiteral;
 import com.google.dart.compiler.ast.DartBinaryExpression;
 import com.google.dart.compiler.ast.DartBlock;
 import com.google.dart.compiler.ast.DartBooleanLiteral;
 import com.google.dart.compiler.ast.DartBreakStatement;
 import com.google.dart.compiler.ast.DartCatchBlock;
 import com.google.dart.compiler.ast.DartClass;
 import com.google.dart.compiler.ast.DartClassMember;
 import com.google.dart.compiler.ast.DartContinueStatement;
@@ skipping 1245 matching lines @@
             return null;
           }
           switch (ElementKind.of(element)) {
             case FIELD:
               FieldElement field = (FieldElement) element;
               x.setType(field.getType());
               if (!field.getModifiers().isStatic()) {
                 onError(x.getName(), ResolverErrorCode.NOT_A_STATIC_FIELD,
                     x.getPropertyName());
               }
-              if (Elements.inSetterContext(x)) {
+              if (ASTNodes.inSetterContext(x)) {
                 if (field.getGetter() != null) {
-                  element = field.getSetter();
-                  if (element == null) {
+                  if (field.getSetter() == null) {
                     onError(x.getName(), ResolverErrorCode.FIELD_DOES_NOT_HAVE_A_SETTER);
                   }
                 }
               }
-              if (Elements.inGetterContext(x)) {
+              if (ASTNodes.inGetterContext(x)) {
                 if (field.getSetter() != null) {
-                  element = field.getGetter();
-                  if (element == null) {
+                  if (field.getGetter() == null) {
                     onError(x.getName(), ResolverErrorCode.FIELD_DOES_NOT_HAVE_A_GETTER);
                   }
                 }
               }
               break;
 
             case NONE:
               onError(x.getName(), TypeErrorCode.CANNOT_BE_RESOLVED,
                   x.getPropertyName());
               break;
@@ skipping 1022 matching lines @@
           ClassElement currentClass = (ClassElement) constructor.getEnclosingElement();
           if (nextClass == currentClass) {
             return (ConstructorNodeElement) nextConstructorElement;
           }
         }
       }
     }
     return null;
   }
 }