editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodAnalyzer.java - Issue 10918260: Issue 5044. Keep FieldElement as Element for field access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodAnalyzer.java

Issue 10918260: Issue 5044. Keep FieldElement as Element for field access (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodRefactoring.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodAnalyzer.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodAnalyzer.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodAnalyzer.java

index b83311d32aa1a23aa1efec1e6cfdc8f0ab664cef..e44abc04cf0bc7d042046aba074b9ff8e45cbc45 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodAnalyzer.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/code/ExtractMethodAnalyzer.java

@@ -23,7 +23,6 @@ import com.google.dart.compiler.ast.DartNode;

import com.google.dart.compiler.ast.DartTypeNode;

import com.google.dart.compiler.ast.DartVariable;

import com.google.dart.compiler.resolver.ElementKind;

-import com.google.dart.compiler.resolver.Elements;

import com.google.dart.tools.core.dom.PropertyDescriptorHelper;

import com.google.dart.tools.core.model.CompilationUnit;

import com.google.dart.tools.internal.corext.refactoring.RefactoringCoreMessages;

@@ -48,7 +47,7 @@ public class ExtractMethodAnalyzer extends StatementAnalyzer {

public Void visitBinaryExpression(DartBinaryExpression node) {

super.visitBinaryExpression(node);

DartExpression lhs = node.getArg1();

- if (isFirstSelectedNode(lhs) && Elements.inSetterContext(lhs)) {

+ if (isFirstSelectedNode(lhs) && ASTNodes.inSetterContext(lhs)) {

invalidSelection(

RefactoringCoreMessages.ExtractMethodAnalyzer_leftHandSideOfAssignment,

DartStatusContext.create(fCUnit, node));