Issue 10909209: Eliminate the const constructor from the Expando class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909209: Eliminate the const constructor from the Expando class. (Closed)

Created:
8 years, 3 months ago by cshapiro

Modified:
8 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Eliminate the const constructor from the Expando class. Committed: https://code.google.com/p/dart/source/detail?r=12354

Patch Set 2 : address review comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -145 lines)			Patch
M	lib/compiler/implementation/lib/core_patch.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/core/expando.dart	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/lib/expando_patch.dart	View	1	2 chunks	+17 lines, -43 lines	0 comments	Download
M	tests/corelib/expando_test.dart	View		1 chunk	+69 lines, -98 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM with comment. http://codereview.chromium.org/10909209/diff/1/runtime/lib/expando_patch.dart File runtime/lib/expando_patch.dart (right): http://codereview.chromium.org/10909209/diff/1/runtime/lib/expando_patch.dart#newcode10 runtime/lib/expando_patch.dart:10: if (_data !== null) { If ...

8 years, 3 months ago (2012-09-13 20:06:48 UTC) #2

cshapiro

8 years, 3 months ago (2012-09-13 21:19:41 UTC) #3

http://codereview.chromium.org/10909209/diff/1/runtime/lib/expando_patch.dart
File runtime/lib/expando_patch.dart (right):

http://codereview.chromium.org/10909209/diff/1/runtime/lib/expando_patch.dart...
runtime/lib/expando_patch.dart:10: if (_data !== null) {
Good idea.  Done.

Expand Messages | Collapse Messages

Issue 10909209: Eliminate the const constructor from the Expando class. (Closed)

Description

Patch Set 1 #

Patch Set 2 : address review comments #

Messages