lib/core/expando.dart - Issue 10909209: Eliminate the const constructor from the Expando class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/core/expando.dart

Issue 10909209: Eliminate the const constructor from the Expando class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address review comments Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/core/expando.dart

diff --git a/lib/core/expando.dart b/lib/core/expando.dart

index 901cee5c29ed24d621ed3d940031bd33c43c5745..f027893ece0b0d39af2668229415b43909f28d61 100644

--- a/lib/core/expando.dart

+++ b/lib/core/expando.dart

@@ -15,11 +15,11 @@ class Expando<T> {

/**

* Creates a new [Expando]. The optional name is only used for

- * debugging purposes and creating two different (non-const)

- * [Expando]s with the same name yields two [Expando]s that work on

- * different properties of the objects they are used on.

+ * debugging purposes and creating two different [Expando]s with the

+ * same name yields two [Expando]s that work on different properties

+ * of the objects they are used on.

- const Expando([String this.name]);

+ external Expando([String name]);

/**

* Expando toString method override.

« no previous file with comments | « lib/compiler/implementation/lib/core_patch.dart ('k') | runtime/lib/expando_patch.dart » ('j') | no next file with comments »