Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Side by Side Diff: lib/core/expando.dart

Issue 10909209: Eliminate the const constructor from the Expando class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address review comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « lib/compiler/implementation/lib/core_patch.dart ('k') | runtime/lib/expando_patch.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * An [Expando] allows adding new properties to objects. 6 * An [Expando] allows adding new properties to objects.
7 */ 7 */
8 class Expando<T> { 8 class Expando<T> {
9 9
10 /** 10 /**
11 * The name of the this [Expando] as passed to the constructor. If 11 * The name of the this [Expando] as passed to the constructor. If
12 * no name was passed to the constructor, the name is [null]. 12 * no name was passed to the constructor, the name is [null].
13 */ 13 */
14 final String name; 14 final String name;
15 15
16 /** 16 /**
17 * Creates a new [Expando]. The optional name is only used for 17 * Creates a new [Expando]. The optional name is only used for
18 * debugging purposes and creating two different (non-const) 18 * debugging purposes and creating two different [Expando]s with the
19 * [Expando]s with the same name yields two [Expando]s that work on 19 * same name yields two [Expando]s that work on different properties
20 * different properties of the objects they are used on. 20 * of the objects they are used on.
21 */ 21 */
22 const Expando([String this.name]); 22 external Expando([String name]);
23 23
24 /** 24 /**
25 * Expando toString method override. 25 * Expando toString method override.
26 */ 26 */
27 String toString() => "Expando:$name"; 27 String toString() => "Expando:$name";
28 28
29 /** 29 /**
30 * Gets the value of this [Expando]'s property on the given 30 * Gets the value of this [Expando]'s property on the given
31 * object. If the object hasn't been expanded, the method returns 31 * object. If the object hasn't been expanded, the method returns
32 * [null]. 32 * [null].
33 */ 33 */
34 external T operator [](Object object); 34 external T operator [](Object object);
35 35
36 /** 36 /**
37 * Sets the value of this [Expando]'s property on the given 37 * Sets the value of this [Expando]'s property on the given
38 * object. Properties can effectively be removed again by setting 38 * object. Properties can effectively be removed again by setting
39 * their value to null. 39 * their value to null.
40 */ 40 */
41 external void operator []=(Object object, T value); 41 external void operator []=(Object object, T value);
42 42
43 } 43 }
OLDNEW
« no previous file with comments | « lib/compiler/implementation/lib/core_patch.dart ('k') | runtime/lib/expando_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698