Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090293003: Kill service_test.cc tests in favor of dart tests for the service protocol. (Closed)

Created:
5 years, 8 months ago by turnidge
Modified:
5 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org, rmacnak
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Kill service_test.cc tests in favor of dart tests for the service protocol. Associated cleanups and fixes that I noticed as I rewrote the tests. Committed: https://code.google.com/p/dart/source/detail?r=45257

Patch Set 1 #

Total comments: 4

Patch Set 2 : tweak ui for sample instances #

Patch Set 3 : code review #

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+996 lines, -1053 lines) Patch
M runtime/observatory/lib/src/elements/class_view.html View 1 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_map.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.html View 1 chunk +4 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_view.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 5 chunks +9 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/allocations_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/async_generator_breakpoint_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/bad_web_socket_address_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/caching_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/tests/service/classes_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
M runtime/observatory/tests/service/code_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/command_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/contexts_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/coverage_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugging_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/dominator_tree_test.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/echo_test.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/eval_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/tests/service/functions_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
M runtime/observatory/tests/service/gc_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
A runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_flag_list_rpc_test.dart View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_heap_map_rpc_test.dart View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_instances_rpc_test.dart View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_isolate_rpc_test.dart View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_object_rpc_test.dart View 1 2 3 1 chunk +369 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_retained_size_rpc_test.dart View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_retaining_path_rpc_test.dart View 1 2 1 chunk +105 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/get_vm_rpc_test.dart View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/graph_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/inbound_references_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/isolate_lifecycle_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/malformed_test.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/metrics_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/mirror_references_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/native_metrics_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/source_location_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/string_escaping_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/type_arguments_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/vm_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/weak_properties_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_table.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 4 chunks +13 lines, -2 lines 0 comments Download
M runtime/vm/pages.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/service.cc View 11 chunks +18 lines, -17 lines 0 comments Download
M runtime/vm/service/service.idl View 2 chunks +19 lines, -10 lines 0 comments Download
M runtime/vm/service_test.cc View 1 2 3 6 chunks +2 lines, -887 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 8 months ago (2015-04-17 17:48:13 UTC) #2
Cutch
LGTMwC https://codereview.chromium.org/1090293003/diff/1/runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart File runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart (right): https://codereview.chromium.org/1090293003/diff/1/runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart#newcode4 runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart:4: // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override --checked remove the --checked ...
5 years, 8 months ago (2015-04-17 20:27:28 UTC) #3
turnidge
https://codereview.chromium.org/1090293003/diff/1/runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart File runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart (right): https://codereview.chromium.org/1090293003/diff/1/runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart#newcode4 runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart:4: // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override --checked On 2015/04/17 20:27:27, Cutch ...
5 years, 8 months ago (2015-04-17 21:04:03 UTC) #4
turnidge
5 years, 8 months ago (2015-04-17 21:08:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 45257 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698