Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1090293003: Kill service_test.cc tests in favor of dart tests for the service protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index cc233f9daae59f40a4ebd8fd22283fe6479da2a8..0459a5a982e9d23d137a7bae13a2e0c7350e83dc 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1182,7 +1182,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
Map params = {
'targetId': target.id,
};
- return invokeRpc('getRetainedSize', params);
+ return invokeRpc('_getRetainedSize', params);
}
Future<ServiceObject> getRetainingPath(ServiceObject target, var limit) {
@@ -1190,7 +1190,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
'targetId': target.id,
'limit': limit.toString(),
};
- return invokeRpc('getRetainingPath', params);
+ return invokeRpc('_getRetainingPath', params);
}
Future<ServiceObject> getInboundReferences(ServiceObject target, var limit) {
@@ -1198,7 +1198,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
'targetId': target.id,
'limit': limit.toString(),
};
- return invokeRpc('getInboundReferences', params);
+ return invokeRpc('_getInboundReferences', params);
}
Future<ServiceObject> getTypeArgumentsList(bool onlyWithInstantiations) {
@@ -1213,7 +1213,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
'classId': cls.id,
'limit': limit.toString(),
};
- return invokeRpc('getInstances', params);
+ return invokeRpc('_getInstances', params);
}
Future<ServiceObject> getObjectByAddress(String address, [bool ref=true]) {
@@ -1295,6 +1295,11 @@ class ServiceMap extends ServiceObject implements ObservableMap {
vmName = (_map.containsKey('vmName') ? _map['vmName'] : name);
}
+ // TODO(turnidge): These are temporary until we have a proper root
+ // object for all dart heap objects.
+ int get size => _map['size'];
+ int get clazz => _map['class'];
+
// Forward Map interface calls.
void addAll(Map other) => _map.addAll(other);
void clear() => _map.clear();
« no previous file with comments | « runtime/observatory/lib/src/elements/object_view.dart ('k') | runtime/observatory/tests/service/allocations_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698