Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: runtime/observatory/lib/src/elements/heap_map.dart

Issue 1090293003: Kill service_test.cc tests in favor of dart tests for the service protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/heap_map.dart
diff --git a/runtime/observatory/lib/src/elements/heap_map.dart b/runtime/observatory/lib/src/elements/heap_map.dart
index 05ed60a9b407ff4cce330e72b7b5d6bcbbc839fd..fc33a5c5001d5e9b3f18ea3f487ef3ae99a4c2bf 100644
--- a/runtime/observatory/lib/src/elements/heap_map.dart
+++ b/runtime/observatory/lib/src/elements/heap_map.dart
@@ -146,9 +146,9 @@ class HeapMapElement extends ObservatoryElement {
break;
}
}
- return new ObjectInfo(int.parse(page['object_start']) +
- pageOffset * fragmentation['unit_size_bytes'],
- size * fragmentation['unit_size_bytes']);
+ return new ObjectInfo(int.parse(page['objectStart']) +
+ pageOffset * fragmentation['unitSizeBytes'],
+ size * fragmentation['unitSizeBytes']);
}
void _handleMouseMove(MouseEvent event) {
@@ -163,7 +163,7 @@ class HeapMapElement extends ObservatoryElement {
isolate.getObjectByAddress(address).then((result) {
if (result is DartError) {
Logger.root.severe(result.message);
- } else {
+ } else if (result.type != 'Sentinel') {
app.locationManager.go(gotoLink('/inspect', result));
}
});
@@ -174,12 +174,12 @@ class HeapMapElement extends ObservatoryElement {
return;
}
_updateClassList(
- fragmentation['class_list'], fragmentation['free_class_id']);
+ fragmentation['classList'], fragmentation['freeClassId']);
var pages = fragmentation['pages'];
var width = _fragmentationCanvas.parent.client.width;
_pageHeight = _PAGE_SEPARATION_HEIGHT +
- fragmentation['page_size_bytes'] ~/
- fragmentation['unit_size_bytes'] ~/ width;
+ fragmentation['pageSizeBytes'] ~/
+ fragmentation['unitSizeBytes'] ~/ width;
var height = min(_pageHeight * pages.length, _MAX_CANVAS_HEIGHT);
_fragmentationData =
_fragmentationCanvas.context2D.createImageData(width, height);
« no previous file with comments | « runtime/observatory/lib/src/elements/class_view.html ('k') | runtime/observatory/lib/src/elements/heap_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698