Issue 108923003: Fix issues that caused revert of r30955:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108923003: Fix issues that caused revert of r30955: (Closed)

Created:
7 years ago by ahe

Modified:
7 years ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix issues that caused revert of r30955: * Don't emit reflection info for unapplicable members (constructors). * Correctly identify unreflectable members supporting Function.apply. * Don't crash when computing function types of top-levels. Committed along with https://codereview.chromium.org/98073005. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=30974

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -7 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart	View	5 chunks	+13 lines, -6 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ahe

This CL will be applied together with CL 98073005. The reason for reverting was that ...

7 years ago (2013-12-06 22:54:56 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r30974 (presubmit successful).