Issue 98073005: Generate tear-off closures dynamically, second attempt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98073005: Generate tear-off closures dynamically, second attempt. (Closed)

Created:
7 years ago by ahe

Modified:
7 years ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Generate tear-off closures dynamically, second attempt. Committed along with https://codereview.chromium.org/108923003. Original review URL: https://codereview.chromium.org/27524003. Committed: https://code.google.com/p/dart/source/detail?r=30974

Patch Set 1 #

Patch Set 2 : Merged with r30973. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1111 lines, -613 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js/nodes.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		4 chunks	+9 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_builder.dart	View		2 chunks	+35 lines, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart	View		6 chunks	+14 lines, -22 lines	0 comments	Download
D	dart/sdk/lib/_internal/compiler/implementation/js_emitter/closure_invocation_element.dart	View		1 chunk	+0 lines, -25 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View		8 chunks	+17 lines, -20 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart	View		8 chunks	+234 lines, -356 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/declarations.dart	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart	View		4 chunks	+6 lines, -18 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/nsm_emitter.dart	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart	View		7 chunks	+184 lines, -7 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/universe/universe.dart	View		3 chunks	+21 lines, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/isolate_helper.dart	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_helper.dart	View		8 chunks	+394 lines, -46 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View		17 chunks	+149 lines, -80 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_rti.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/mirrors_used_test.dart	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js/static_closure_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/types_of_captured_variables_test.dart	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/deferred/deferred_function_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/mirror_invalid_field_access4_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/mirror_invalid_invoke2_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js_extra/mirror_invalid_invoke3_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/lib/lib.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download